dojo.declare()'s createSubclass() features, tests, and docs

[bill]

dojo.declare()'s createSubclass() added in [27667] is awkward to use to add new methods to the new class. You need to do:

var MyClass = BaseClass.createSubclass([A, B]);
MyClass.extend({
   newMethod: function(){ ... }
});

rather than what I would expect:

var MyClass = BaseClass.createSubclass([A, B], {
   newMethod: function(){ ... }
});

A fuller test case is:

var MyMixin = dojo.declare(null, {
   postCreate: function(){
       this.inherited(arguments);
       console.log("MyMixin postCreate");
   }
});
var MyMenu = dijit.Menu.createSubclass(MyMixin, {
   postCreate: function(){
       this.inherited(arguments);
       console.log("MyMenu postCreate");
   }
});
new MyMenu();

Also, it should have some tests, and documentation in the reference guide.

[bill]

FYI, ticket submitted in response to ​http://thread.gmane.org/gmane.comp.web.dojo.devel/18414/focus=18440.

[cjolif]

To be honest I did add this method mostly for the profit of the parser (data-dojo-mixins), not necessarily thinking about end-users using it as well directly, thus the lack of doc. Note that even if there is no direct tests it is tested through the parser tests which uses it.

That said you are right it certainly makes sense to add direct tests, docs and improve API. I'll try to do that for 1.9.

[cjolif]

possible patch to implement props argument in createSubclass, add inline doc and tests

[cjolif]

If no comments, I'll proceed with that one and document this on the reference guide as well.

[cjolif]

In [30427]:

fixes #16505. Document, test, and add mixin parameter to declare.createSubclass. !strict.

[Colin Snover]

In [30735]:

Fix invalid dojodoc for createSubclass. Refs #16505. !strict due to existing invalid code.