Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#165 closed defect (fixed)

Dialog widget places form dialog outside visibale area in konqueror

Reported by: fredrik dot j at bredband dot net Owned by: david
Priority: high Milestone:
Component: General Version:
Keywords: Dialog khtml unvisible Cc:
Blocked By: Blocking:

Description

The Dialog widget places the dialog in the middle of document instead of middle of visible area in konqueror. It also turns the background completly black, but I guess thats because Konqi doesnt support opacity yet..

Anyways If you change line 120 of Dialog.js in rev 1834 from

var H1 = document.documentElement.clientHeight;

to

var H1 = (window.innerHeight)?window.innerHeight:document.documentElement.clientHeight;

then it places in middle of visible area in konqi to.

I have only tried this change in Konqueror 3.4.3 and FF 1.0.7

/ Fredrik J

Attachments (1)

html.js.diff (2.1 KB) - added by fredrik dot j at bredband dot net 14 years ago.
Patch for html.js dojo.html.getDocumentHeight()

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by david

Owner: changed from anonymous to david
Status: newassigned

[1837] should fix this issue. Please update and try.

Changed 14 years ago by fredrik dot j at bredband dot net

Attachment: html.js.diff added

Patch for html.js dojo.html.getDocumentHeight()

comment:2 Changed 14 years ago by fredrik dot j at bredband dot net

Hi ! Tested it with rev 1837, and I did a complete checkout to 1859, but it doesnt work.

Some debug values for you: line 124 Dialog.js var T = scrollTop + (H - h)/2; dj_debug("("+H+"-"+h+")="+(H-h));

in Konqueror DEBUG: (2208-126)=2082

in FF DEBUG: (821-120)=701

and debug value from line 102 in dojo.html.getDocumentHeight if(docElm && body) { dj_debug("docElm:"+docElm.clientHeight+" && body:"+body.clientHeight);

Konqueror DEBUG: docElm:2198 && body:2172

FF DEBUG: docElm:821 && body:2077

It seems that Konqueror handles documentElement.clientHeight as if one were requesting the hole documentheight not just the visible part.

I found some info on this page. http://www.howtocreate.co.uk/tutorials/index.php?tut=0&part=16

So the dojo.html.getDocumentHeight propably needs some tweeking. Iam still learning dom and javascript and since its not my profession its taking some time, so please dont jump of the chair if my attached code is awkward, wrong or strange... Anyways attached diff works for me in both Konqueror and FF

comment:3 Changed 14 years ago by david

Resolution: fixed
Status: assignedclosed

(In [1862]) Hopefully this fixes #165, please reopen if it doesn't

comment:4 Changed 12 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.