Dialog widget places form dialog outside visibale area in konqueror

[fredrik dot j at bredband dot net]

The Dialog widget places the dialog in the middle of document instead of middle of visible area in konqueror. It also turns the background completly black, but I guess thats because Konqi doesnt support opacity yet..

Anyways If you change line 120 of Dialog.js in rev 1834 from

var H1 = document.documentElement.clientHeight;

to

var H1 = (window.innerHeight)?window.innerHeight:document.documentElement.clientHeight;

then it places in middle of visible area in konqi to.

I have only tried this change in Konqueror 3.4.3 and FF 1.0.7

/ Fredrik J

[david]

[1837] should fix this issue. Please update and try.

[fredrik dot j at bredband dot net]

Patch for html.js dojo.html.getDocumentHeight()

[fredrik dot j at bredband dot net]

Hi ! Tested it with rev 1837, and I did a complete checkout to 1859, but it doesnt work.

Some debug values for you: line 124 Dialog.js var T = scrollTop + (H - h)/2; dj_debug("("+H+"-"+h+")="+(H-h));

in Konqueror DEBUG: (2208-126)=2082

in FF DEBUG: (821-120)=701

and debug value from line 102 in dojo.html.getDocumentHeight if(docElm && body) { dj_debug("docElm:"+docElm.clientHeight+" && body:"+body.clientHeight);

Konqueror DEBUG: docElm:2198 && body:2172

FF DEBUG: docElm:821 && body:2077

It seems that Konqueror handles documentElement.clientHeight as if one were requesting the hole documentheight not just the visible part.

I found some info on this page. ​http://www.howtocreate.co.uk/tutorials/index.php?tut=0&part=16

So the dojo.html.getDocumentHeight propably needs some tweeking. Iam still learning dom and javascript and since its not my profession its taking some time, so please dont jump of the chair if my attached code is awkward, wrong or strange... Anyways attached diff works for me in both Konqueror and FF

[david]

(In [1862]) Hopefully this fixes #165, please reopen if it doesn't

[(none)]

Milestone 0.2release deleted