DND breaks controller/selector/events

[ilia]

See treeV3/dndselector.html

Move or try moving a node, then click on it. Event handler will not work, while it should (try other nodes).

[ilia]

P.S The problem looks not tree-specific at all.

[ilia]

The cause of the problem is this code:

squelchOnClick: function(e){
		// squelch this onClick() event because it's the result of a drag (it's not a real click)
		dojo.event.browser.stopEvent(e);

		// disconnect after a short delay to prevent "Null argument to unrollAdvice()" warning
		dojo.lang.setTimeout(function() {
				dojo.event.disconnect(this.domNode, "onclick", this, "squelchOnClick");
			},50);
	},

It squelches all onclicks and doesn't really disconnect. I think we can remove setTimeout, then it disconnects, but anyway consumes first click.

I couldn't find out how it *should* work, so can't fix it. Maybe add additional disconnect conditions..

The bug is: all onclick events are blocked after dnd attempt.

[bill]

Hmm, I can take a look at this for 0.4.1. I'm certainly not going to hold up the 0.4 release for it. Last time I checked that code was working correctly; if you mouse down, move the mouse, and then mouse up (a drag operation), it stops the onClick event from firing on said node. It shouldn't block the onClick event if you don't move the mouse while the button is depressed.

[ilia]

Ok, I tested in FF 1.5 under linux, IE 6 under windows.

[ilia]

Ouch closed on mistake.

[swessels@…]

Patch works in IE7, FF2.0

[bill]

(In [6315]) Fixes #1649

[guest]

mmm I try but it didn't work... (firefox 2.0)... besides ¿who really use firefox 2.0 or Explorer 7?

[guest]

It works in firefox and explorer 6... sorry...

[bill]

This is working. (The guest above said "It works in firefox and explorer 6" plus I just tested it myself in FF2.0.)

[(none)]

Milestone 0.4.1 deleted