#16487 closed defect (fixed)
[regression] the build tool is broken on osx
| Reported by: | ben hockey | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.8.3 |
| Component: | BuildSystem | Version: | 1.8.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
r30138 broke the build system when being used on "darwin"
has.add("is-windows", /win/.test(process.platform));
it doesn't take much to join the dots on this one... darwin is not windows.
this was found in the 1.8.2 release
Change History (7)
comment:1 Changed 9 years ago by
| Milestone: | tbd → 1.8.3 |
|---|---|
| Priority: | undecided → blocker |
comment:2 Changed 9 years ago by
| Status: | new → assigned |
|---|---|
| Version: | 1.8.2rc1 → 1.8.2 |
comment:3 Changed 9 years ago by
comment:4 Changed 9 years ago by
Oh sh.... I totally missed the darwin use case.. I first thought to change the test to ^win, but indeed you are right, a stricter 'win32' seems better, since it is documented...
comment:5 Changed 9 years ago by
FYI, I attached a new patch for trunk (since node.js support on windows has not been commited yet in trunk) to #15413
comment:7 Changed 9 years ago by
| Summary: | the build tool is broken on osx → [regression] the build tool is broken on osx |
|---|
Note: See
TracTickets for help on using
tickets.
According to the documentation there is a limited list of valid values that are returned. My opinion is we should stick to documented values and this should be:
has.add("is-windows", process.platform == "win32");Instead of getting "fancy" and not anchoring our RegEx or predicting what might be returned in the future.