Opened 7 years ago

Closed 4 years ago

#16484 closed enhancement (patchwelcome)

Tidy Rotator to use mid notation and not require globals

Reported by: Nick Fenwick Owned by: dante
Priority: undecided Milestone: 1.13
Component: DojoX Widgets Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Following on from #13966 it seems work still needs doing to make dojox/widget/Rotator look up objects by mid rather than requiring globals. #13966 was left with the comment:

  • "Still using global variables to access the transitions. They should be specified as MIDs or MID/property combos, ex: "dojox/widget/Slide.slideDown".
    • Some code using deprecated APIs like dojo.connect()... but this is a separate concern from AMD.

I just used Rotator in a custom templated dijit of my own, and resorted to using data-dojo-props="transition: 'dojox.widget.rotator.crossFade'. Similarly, if passing an easing function, one might use data-dojo-props="easing: 'easing.cubicInOut' where easing has been exposed globally, or just refer to the existing global dojo.fx.easing.cubicInOut .. either way it's going to be horrible in 2.0 in a custom dijit.

I don't think I have the skills right now to enhance Rotator to use the MID notation, though I could have a go if pointed in the right direction, especially the MID/property combo mentioned above. I'm also unclear on the difference between passing in easing and transition directives programmatically vs declaratively.

It would be good to get this in before 2.0, as it might involve quite a change in the usage of Rotator. Can someone mark it as required for 2.0 if you agree, please?

Change History (1)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.