Opened 6 years ago

Closed 6 years ago

#16444 closed defect (invalid)

_OnDijitClickMixin should be merged with _Widget

Reported by: Randy Hudson Owned by: bill
Priority: undecided Milestone: tbd
Component: Dijit Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Why is one function from _Widget separated into its own mix-in module that can't really be mixed in to anything other than a widget (it assumes an inherited connect()), and is already mixed in to _Widget for you? Why does DropDownMenu? mix it in again?

Change History (1)

comment:1 Changed 6 years ago by bill

Resolution: invalid
Status: newclosed

There are lots of modules in dijit that can only be mixed in to a widget. They are called "mixins". These optional features exist in independent modules so that they aren't downloaded unless necessary.

Probably you are confused between _Widget and _WidgetBase. _WidgetBase is the new bare-essentials base class for widgets going forwards. Most of the dijit widgets still extend _Widget though, for backwards compatibility. Probably at one point MenuBase extended _WidgetBase rather than _Widget, hence DropDownMenu needed to extend _OnDijitClickMixin. Or at least that was the plan. It will be that way eventually.

Note: See TracTickets for help on using tickets.