exception in IE relating to focus event when browser window reselected

[DaveHS]

We have a grid within a tab container - double clicking on items in the grid opens a details record in a new tab. If the user clicks away from the browser at this point e.g. switches to another open application, then switches back to the browser, a javascript error is reported:

SCRIPT5007: Unable to get value of the property 'toLowerCase': object is null or undefined

This only happens if the browser is in strict mode (example attached).

We have traced this to the dijit focus.js code - a one line change is all that is required to fix it (we can supply details).

[DaveHS]

Sample file showing the issue

[DaveHS]

Patch file with single line change to prevent the error.

[bill]

OK, I'll take a look. Thanks for the test file and patch.\

Do you happen to know what strange element is getting the focusin event? There's no tagName so I wonder if it's a text node or ... ?

[DaveHS]

Replying to bill:

OK, I'll take a look. Thanks for the test file and patch.\

Do you happen to know what strange element is getting the focusin event? There's no tagName so I wonder if it's a text node or ... ?

Sorry, no idea - we can see that the event's srcElement object doesn't have a tagName - it looks like an empty object in the debugger... The last item to (sucessfully) have the focus is the TD from the grid.

Thanks for looking at it!

[bill]

Indeed, very strange. OK, sure, I can check that in. BTW this happens in IE10 too.

The error is not critical since it aborts the exception aborts the handler in the same as the "return" statement in your patch, but I'll glady check it in anyway, to keep the console clean.

[bill]

In [30137]:

Avoid exception on IE when browser window refocused after switching to another application. Thanks DaveHS, fixes #16437 !strict.

[DaveHS]

Thanks for doing that - and for checking it in IE10 too!

[bill]

#17096 is a duplicate of this ticket.

[Bill Keese <bill@…>]

In d22a72b0d372e1b7f2496396dcd009be7711736c/dijit:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?