Opened 13 years ago

Closed 12 years ago

#1643 closed defect (invalid)

dnd for 3 trees and a document

Reported by: schuermann@… Owned by: psowden
Priority: high Milestone: 0.9
Component: DnD Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

I have a document and 3 large trees (> 200 elements) in one document. In the beginning the scroll performance was very slow. Profiling brought up that the calculation of x and y positions for the elements are done way to often. The result is a load of 100% on the cpu when scrolling that tree.

Some findings:

  • more than one file manages dnd. both seemed to be active
  • activity in the tree (srolling) triggered code in the normal drag manager
  • changing line 480 from HtmlDragManager?.js to dojo.event.connect(window, "onscroll", dm, "onScroll"); still ets the trees drag and drop work and other (non scrollable, others not tested) elements are still draggable

Anyway .. i had a interesting week and these are my results:

  • drag and drop for document and tree dont work easily together .. the number calculations for the new x,y pos seems to be greater than the actual dom nodes in the document
  • putting a event listener for scroll on the whole document and triggering the chain of events alwayys seems not to be the best way (as the author suggests there)

-maybe the code can be unified for dnd-tree and dnd rest of the system ... a lot of events get attached for nothing (i guess)

Sorry for the bug w.o. a example but its ndc'ed code that can not be published.

Change History (2)

comment:1 Changed 13 years ago by dylan

Milestone: 0.5

comment:2 Changed 12 years ago by Adam Peller

Resolution: invalid
Status: newclosed

tree+dnd are being completely rewritten for 0.9

Note: See TracTickets for help on using tickets.