Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16418 closed defect (fixed)

IE10 quirksmode dojo/query/acme attribute test failure

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.6.2
Component: Query Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

See attached test case. [30019] removed the quirks test for IE10 but of course that doesn't fix the actual bug.

query('> [qux]', 'container')

is not finding the nodes with attribute "qux" set. Both IE9 and IE10 take the DOM path (rather than the querySelectorAll() path), perhaps because it's quirksmode. They end up running the test:

caseSensitive ? elem.getAttribute(cond) : elem[cond]||elem[clc]

Since caseSensitive is false, it ends up checking elemqux?, which works on IE9 but not on IE10, nor on other browsers like FF.

Attachments (1)

queryQuirks.html (18.3 KB) - added by bill 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by bill

Attachment: queryQuirks.html added

comment:1 Changed 7 years ago by bill

Description: modified (diff)
Milestone: tbd1.8.2
Owner: changed from Kris Zyp to bill
Status: newassigned
Summary: IE10 dojo/query failures in quirks modeIE10 quirksmode dojo/query/acme attribute test failure

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30105]:

Fix acme bug with attribute selectors in IE10 quirks mode. Although IE10 is working now, there's still a lot of has("ie") browser sniffing in acme.js that would be nice to get rid of, because it's probably doing stuff that IE10 doesn't need.

Restored the quirks mode query tests removed in [30019]. This essentially makes two copies of query.html; the alternative is to use dijit/tests/_loadTest.js, but that's in dijit rather than core. Also, not running the quirks mode tests from the test runner (i.e. from dojo/tests/query.js) due to the IE9+ problem where the iframe is in quirks mode but the parent is standards mode.

Fixes #16418 on trunk !strict.

comment:3 Changed 7 years ago by bill

In [30106]:

Backport acme selector fix for IE10 quirks mode to 1.8 branch, fixes #16418 on 1.8 branch !strict.

comment:4 Changed 7 years ago by bill

In [30249]:

Backport acme selector fix for IE10 quirks mode to 1.7, fixes #16418 on 1.7 branch !strict

comment:5 Changed 7 years ago by bill

In [30250]:

Backport acme selector fix for IE10 quirks mode to 1.6, fixes #16418 on 1.6 branch !strict

comment:6 Changed 7 years ago by bill

Milestone: 1.8.21.6.2
Note: See TracTickets for help on using tickets.