Changes between Version 1 and Version 2 of Ticket #16414, comment 24


Ignore:
Timestamp:
Jul 6, 2013, 5:39:28 AM (8 years ago)
Author:
Colin Snover
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16414, comment 24

    v1 v2  
    11While the canonical path separator in Windows is a backslash, Windows APIs are OK with forward-slashes in file paths (it is only the command-line interpreters that are not) and Node.js on Windows is as well. Also the patch only replaces the *first* forward-slash, and it only replaces it on the *output* of `require.toUrl`, which seems wrong no matter which way you slice it. I implemented a simpler version of this in dojo2-core similar to what I stated in comment #22 (I think it could actually be as simple as what is in comment #22) and it works fine on Windows.
     2
     3https://github.com/csnover/dojo2-core/blob/dfc544969d5d7347ba8f9700e2c84f8765400820/node.js#L48-L53
     4https://github.com/csnover/dojo2-core/blob/dfc544969d5d7347ba8f9700e2c84f8765400820/tests/node.js#L15-L20