Changes between Initial Version and Version 1 of Ticket #16414, comment 22


Ignore:
Timestamp:
Jul 5, 2013, 2:23:05 AM (8 years ago)
Author:
Colin Snover
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16414, comment 22

    initial v1  
    1 Kitson, why does this patch use `path.sep` to generate a module ID for Node.js? CommonJS module IDs and AMD module IDs follow the same semantics (forward-slashes) so I don’t understand why this is being done.
     1Kitson, why does this patch use `path.sep` to generate a module ID for Node.js? CommonJS module IDs and AMD module IDs follow the same semantics (forward-slashes) so I don’t understand why this is being done. Actually I don’t understand why it is any more complicated than `id = require.toUrl(normalize(id));`.