Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#16412 closed defect (wontfix)

InlineEditBox: dijit/Editor editor with autosave=true broken on Opera

Reported by: Christoph Zwerschke Owned by: bill
Priority: low Milestone: 1.9
Component: Dijit Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

When you create an InlineEditBox? based on the rich text Editor with autosave=true, it will not be usable with Opera (Dojo 1.8.1, Opera 12.11). The problem is that if you click the text to be edited, the editor pops up and then immediately closes again. The reason for that seems to be that clicking the text focuses the iframe of the RTE which causes an onBlur on the textarea which closes the editor again.

You can use dijit/tests/test_InlineEditBox.html to reproduce the problem, just change autosave=false to autosave=true in the RTE test. Sometimes it seems to work, but only if you immediately click on the textarea again when it pops up after clicking the text. But this works only because the text inside the editor in the test is quite large. If there is less text, you have no chace.

I have attached a small patch that fixes the issue for me.

Attachments (1)

RichText.js.patch (595 bytes) - added by Christoph Zwerschke 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Christoph Zwerschke

Attachment: RichText.js.patch added

comment:1 Changed 7 years ago by bill

Owner: changed from bill to Christoph Zwerschke
Status: newpending

I'm confused... how can you expect to use InlineEditBox with Editor in autosave=true mode? As soon as the user hits the return key in the editor (to start typing a new paragraph), won't it unwantedly treat that as a save command?

comment:2 Changed 7 years ago by Christoph Zwerschke

Status: pendingnew

No, the return key will not save the editor content, it will start a new paragraph. The content is saved when the editor looses focus, e.g. with the tab key or by clicking elsewhere. And even if the return key would save the content, you could still use Shift+Return for creating new paragraphs. So that's not a problem.

comment:3 Changed 7 years ago by bill

Milestone: tbd1.9
Owner: changed from Christoph Zwerschke to bill
Status: newassigned
Summary: RichText Autosave InlineEditBox does not work with OperaInlineEditBox: dijit/Editor editor with autosave=true broken on Opera

I see, OK so most people would close the editor by clicking elsewhere.

Well, Opera isn't supported by dijit but I suppose I could add that code. I'm not sure why the other browsers are focusing the iframe itself, rather than <body> node (like your suggested patch for Opera does).

comment:4 Changed 7 years ago by bill

Priority: undecidedlow

comment:5 Changed 6 years ago by bill

Resolution: wontfix
Status: assignedclosed

Given that Opera is switching to the webkit engine, it doesn't make sense to look at these tickets. We can re-evaluate behavior of dijit on opera after the switch.

comment:6 Changed 6 years ago by Christoph Zwerschke

I can confirm that it works with Opera Next (Version 15) which is based on Blink.

Note: See TracTickets for help on using tickets.