Opened 6 years ago

Closed 6 years ago

#16392 closed enhancement (invalid)

Manual tests for bidi BTD support

Reported by: hhelena Owned by: hhelena
Priority: undecided Milestone: tbd
Component: Dijit Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Additional manual tests for base text direction in dijit widgets. Covered widgets created programmatically, with markup, changing textDir dynamically, different GUI orientation. Can be useful for Bidi testing with other languages, for example Arabic.

Attachments (2)

16392.patch (243.4 KB) - added by Douglas Hays 6 years ago.
patch from hhelena (IBM, CCLA)
Bidi_AccordionContainer_fixed.html (12.6 KB) - added by bill 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Douglas Hays

Attachment: 16392.patch added

patch from hhelena (IBM, CCLA)

comment:1 Changed 6 years ago by bill

Owner: changed from bill to hhelena
Status: newpending

Hmm, we don't normally check in non-automated tests, but I guess I could. These test files need to be cleaned up a bit though. I went through Bidi_AccordionContainer.html to:

  • fix tabbing
  • remove trailing spaces/tabs
  • fix duplicate variable declarations
  • remove unneeded requires
  • make button markup degradable; should only use data-dojo-props for non-standard attributes

I'll attach the file I fixed so you can compare.

I also looked at Bidi_Button.html and noticed a problem where buttons have two values specified:

<button data-dojo-type="dijit/form/Button" dir="rtl" 
data-dojo-props='value:"&#1513;&#1500;&#1493;&#1501!", textDir:"auto"'>
Hello World!
</button>

So, please go through the other 27 files checking them over and fixing them too, including looking for other errors.

Changed 6 years ago by bill

comment:2 Changed 6 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.