Changes between Initial Version and Version 1 of Ticket #16373, comment 3


Ignore:
Timestamp:
Nov 28, 2012, 1:51:56 PM (8 years ago)
Author:
Adrian Vasiliu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16373, comment 3

    initial v1  
    55"Dojo base should add some "protection" (at least in development) preventing getting both AMD-async and the legacy loader." - I think the point is that an app may mix old legacy code and new AMD code, so it may need to mix both loaders for loading different pieces of code.
    66
    7 "Change the code in lazyLoadUtils, to check if we have async rather than legacy, like in the patch submitted" - if we'd use your patch, the legacy loader would be used in all cases of sync loading. This is not correct, it must use the sync mode of the new loader. Here, we use the legacy loader if it is explicitly required, and we may get rid of that. But we should not use the legacy loader for any sync loading.
     7"Change the code in lazyLoadUtils, to check if we have async rather than legacy, like in the patch submitted" - I think there's no reason that we use the legacy loader directly just because the config flag is sync. The new loader handles the sync case by itself. We currently use the legacy loader directly if it has been explicitly required, but we may get rid of that.