Opened 6 years ago

Last modified 2 years ago

#16364 assigned task

Deserialized shapes don't keep their IDs

Reported by: gaxweb Owned by: Eric Durocher
Priority: undecided Milestone: 1.15
Component: DojoX GFX Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

If you deserialize an SVG which was converted with the svg2gfx.xsl stylesheet, the generated "name" property in the JSON is not being converted into a id attribute on the svg element it represents.

This makes it very hard to selectively add events on the graphic, for example. So i suggest to add that.

Attachments (1)

keep_IDs.patch (2.1 KB) - added by gaxweb 6 years ago.
A patch that does that.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by gaxweb

Attachment: keep_IDs.patch added

A patch that does that.

comment:1 Changed 6 years ago by gaxweb

The patch will check if an element inside the graphic already has used that ID and will then generate a new one instead, just like it does now.

comment:2 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eugene Lazutkin to Patrick Ruzand
Status: newassigned

comment:3 Changed 6 years ago by Eric Durocher

Owner: changed from Patrick Ruzand to Eric Durocher

comment:4 Changed 3 years ago by dylan

Milestone: tbd1.12

Not sure why this patch was never reviewed. gaxweb, do you have a CLA on file ( see contributing guidelines at https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md )?

We will consider this for 1.12.

comment:5 in reply to:  4 Changed 2 years ago by gaxweb

Replying to dylan:

Not sure why this patch was never reviewed. gaxweb, do you have a CLA on file ( see contributing guidelines at https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md )?

No, I do not. I shall talk to my boss.

comment:6 Changed 2 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.