Opened 7 years ago

Closed 7 years ago

#16360 closed defect (fixed)

StackContainer: does not react on changing textDir of ContentPane

Reported by: hhelena Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

When user changes dynamically textDir property of StackContainer?'s ContentPane? to "rtl", the title still displayed with "ltr" text direction. The same problem is with TabContainer?. See attached test file. "Set textDir to rtl" and "Set textDir to auto" do not work

Attachments (2)

Bidi_StackContainer_test.html (10.1 KB) - added by hhelena 7 years ago.
test file
16360.patch (949 bytes) - added by Douglas Hays 7 years ago.
patch from hhelena (IBM, CCLA)

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by hhelena

test file

Changed 7 years ago by Douglas Hays

Attachment: 16360.patch added

patch from hhelena (IBM, CCLA)

comment:1 Changed 7 years ago by bill

Milestone: tbd1.9
Status: newassigned
Summary: StackContainer does not react on changing textDir of ContentPaneStackContainer: does not react on changing textDir of ContentPane

OK, makes sense, although textDir should be handled in the same place as other properties (like changes to the title itself, or the icon). At a glance, the patch looks like it is handling textDir as a special case.

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29990]:

Make sure changes to StackContainer's children's textdir property gets propagated to corresponding StackController button. Also fixing up test file. Fixes #16360 !strict.

Note: See TracTickets for help on using tickets.