Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16353 closed defect (fixed)

[PATCH][CCLA] dijit.ColorPalette : set role and summary on domNode, add automated tests

Reported by: mikeb Owned by: bill
Priority: undecided Milestone: 1.8.4
Component: Dijit Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Dijit.ColorPalette? has the correct aria roles and attributes. However, the role should be set on the domNode and not the paletteTableNode. This way we can correctly set other aria attributes relating to dropDown functionality, see #16307.

Patch also adds automated test cases to check for the correct roles (grid on domNode, presentation on the <table>, row on the <tr> and gridcell on the <td>).

Attachments (2)

set-colorPalette-role-on-dom-add-automated-tests.patch (5.2 KB) - added by mikeb 7 years ago.
Move _paletteMixin aria role to the domNode, add automated test cases, please proxy commit for Michael Billau CCLA on file with IBM
backport-palette-accessibility-fixes.patch (5.6 KB) - added by mikeb 7 years ago.
Backport accessibility fixes from _Palette to 1.8, includes 29981, 29905, 29892, please proxy commit for michael billau CCLA on file (IBM)

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by mikeb

Move _paletteMixin aria role to the domNode, add automated test cases, please proxy commit for Michael Billau CCLA on file with IBM

comment:1 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [29981]:

Move _PaletteMixin grid aria role to the domNode, patch from Michael Billau (IBM, CCLA), fixes #16353 !strict, thanks!

comment:2 Changed 7 years ago by bill

Milestone: tbd1.9

Thanks, I checked in a modified version of your patch:

  • Since aria-label is now being mapped to this.domNode, you don't need any code at all; it happens automatically thanks to code in _WidgetBase.js.
  • Some of your changes to test_ColorPalette.html were already there.
  • in the test file there's no reason for a setTimeout() (or doh.robot.sequence() call) before testing aria roles.

comment:3 Changed 7 years ago by mikeb

Hello. Can we please backport all of the _PaletteMixin / ColorPalette? accessibility functionality to 1.8?

I created a patch that combines these changesets: [29981], [29905], [29892]. It passed the automated test cases. I compared all of the changed files with the version in trunk and they are all the same, except for _PaletteMixin, where the patched version is missing the changes from [30275] (require _OnDijitClickMixin) and from [30255] (fix API doc). The test page has no accessibility violations.

Version 0, edited 7 years ago by mikeb (next)

Changed 7 years ago by mikeb

Backport accessibility fixes from _Palette to 1.8, includes 29981, 29905, 29892, please proxy commit for michael billau CCLA on file (IBM)

comment:4 Changed 7 years ago by bill

This seems safe to backport. The patch is a combo of a backport for #15960, #16274, and this ticket #16353.

Last edited 7 years ago by bill (previous) (diff)

comment:5 Changed 7 years ago by Douglas Hays

In [30315]:

Refs #15960, #16274, #16353. Backport [29892], [29905], [29981] to 1.8.

comment:6 Changed 7 years ago by Douglas Hays

Milestone: 1.91.8.4
Note: See TracTickets for help on using tickets.