Opened 7 years ago

Closed 5 years ago

#16320 closed defect (fixed)

[patch] dojox/form/resources/CheckedMultiSelect.css references images that don't exist

Reported by: ben hockey Owned by: Kitson Kelly
Priority: high Milestone: 1.8.7
Component: DojoX Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by ben hockey)

dojox/form/resources/CheckedMultiSelect.css references "../../../dijit/themes/claro/form/images/textBox_back.png" and "../../../dijit/themes/claro/form/images/formHighlight.png" which don't exist. this causes the build to fail with a few errors like:

error(357) While optimizing a CSS file, it was impossible to compute the destination location of a relative URL. CSS file: /Users/neonstalwart/code/app/app.css; import: /Users/neonstalwart/code/dojox/form/resources/CheckedMultiSelect.css; relative URL: url('../../../dijit/themes/claro/form/images/textBox_back.png')

Attachments (2)

CheckedMultiSelect.css (9.0 KB) - added by tsemachh 6 years ago.
Changes we did to resolve that issue , Styles copied from Select.css
checkbox_css.patch (2.5 KB) - added by bill 6 years ago.
diff version of changes. spacing should be fixed. also, there's no cla, albeit the changes are pretty minor.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 7 years ago by ben hockey

Cc: Adam Peller added
Description: modified (diff)

comment:2 Changed 7 years ago by ben hockey

Cc: Adam Peller removed

oops didn't mean to add peller

Changed 6 years ago by tsemachh

Attachment: CheckedMultiSelect.css added

Changes we did to resolve that issue , Styles copied from Select.css

comment:3 Changed 6 years ago by tsemachh

Becasue of changes done to Claro some of the referenced Images referenced from that file are no longer exists. This makes Build fail on that issue , attached is the fix

Changed 6 years ago by bill

Attachment: checkbox_css.patch added

diff version of changes. spacing should be fixed. also, there's no cla, albeit the changes are pretty minor.

comment:4 Changed 6 years ago by bill

Summary: dojox/form/resources/CheckedMultiSelect.css references images that don't exist[patch] dojox/form/resources/CheckedMultiSelect.css references images that don't exist

tsemachh, can you (electronically) sign the CLA?

comment:5 Changed 6 years ago by Kitson Kelly

Owner: changed from dante to Kitson Kelly
Status: newassigned

comment:6 Changed 6 years ago by Martin Minka

could this pls. be applied to 1.9.0 ? Dojo Builder fails because of this problems

comment:7 Changed 6 years ago by Martin Minka

looking at the current CheckedMultiSelect?.css it seams that only formHighlight.png is not fixed

comment:8 Changed 6 years ago by Philippe Soares

+1 for me on dojo 1.9.1. I use an @import statement on a .less file, and the loader complains with this error :

error(357) While optimizing a CSS file, it was impossible to compute the destination location of a relative URL.

CSS file: [...]mytheme.css; import: /[...]/js/src/dojox/form/resources/CheckedMultiSelect.css; relative URL: url("../../../dijit/themes/claro/form/images/formHighlight.png")

comment:9 Changed 5 years ago by DH

As of 1.9.2 this is still not fixed. In my case, it prevents our dojo-boilerplate-based project from compiling correctly.

Even if the correct replacement CSS needs hammering out, can we at least get the bad line removed?

Last edited 5 years ago by DH (previous) (diff)

comment:10 Changed 5 years ago by Philippe Soares

Still not fixed in 1.10.1-pre

I'm forced to reapply the patch on each dojo upgrade...

comment:11 Changed 5 years ago by dylan

Milestone: tbd1.10.1

I'll try to land this next week, if someone doesn't get to it first.

comment:12 Changed 5 years ago by dylans <dylan@…>

In a429a4600494f891b856c9b43fa45fbb61eef5d4/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:13 Changed 5 years ago by dylans <dylan@…>

In 161d95f0329eb1eb49766dea96493c2eb36808cb/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:14 Changed 5 years ago by dylans <dylan@…>

In 38326563937ddbcfd5d288a967f75b454ab094b6/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:15 Changed 5 years ago by dylans <dylan@…>

In 960cf2db00108d3b35fbc7ed5851ba1fe476ea8c/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:16 Changed 5 years ago by dylan

Milestone: 1.10.11.8.7
Priority: undecidedhigh
Resolution: fixed
Status: assignedclosed

Fixed and backported through 1.8.x

Note: See TracTickets for help on using tickets.