Opened 7 years ago
Closed 6 years ago
#16320 closed defect (fixed)
[patch] dojox/form/resources/CheckedMultiSelect.css references images that don't exist
| Reported by: | ben hockey | Owned by: | Kitson Kelly |
|---|---|---|---|
| Priority: | high | Milestone: | 1.8.7 |
| Component: | DojoX Form | Version: | 1.8.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
dojox/form/resources/CheckedMultiSelect.css references "../../../dijit/themes/claro/form/images/textBox_back.png" and "../../../dijit/themes/claro/form/images/formHighlight.png" which don't exist. this causes the build to fail with a few errors like:
error(357) While optimizing a CSS file, it was impossible to compute the destination location of a relative URL. CSS file: /Users/neonstalwart/code/app/app.css; import: /Users/neonstalwart/code/dojox/form/resources/CheckedMultiSelect.css; relative URL: url('../../../dijit/themes/claro/form/images/textBox_back.png')
Attachments (2)
Change History (18)
comment:1 Changed 7 years ago by
| Cc: | Adam Peller added |
|---|---|
| Description: | modified (diff) |
comment:2 Changed 7 years ago by
| Cc: | Adam Peller removed |
|---|
Changed 7 years ago by
| Attachment: | CheckedMultiSelect.css added |
|---|
Changes we did to resolve that issue , Styles copied from Select.css
comment:3 Changed 7 years ago by
Becasue of changes done to Claro some of the referenced Images referenced from that file are no longer exists. This makes Build fail on that issue , attached is the fix
Changed 7 years ago by
| Attachment: | checkbox_css.patch added |
|---|
diff version of changes. spacing should be fixed. also, there's no cla, albeit the changes are pretty minor.
comment:4 Changed 7 years ago by
| Summary: | dojox/form/resources/CheckedMultiSelect.css references images that don't exist → [patch] dojox/form/resources/CheckedMultiSelect.css references images that don't exist |
|---|
tsemachh, can you (electronically) sign the CLA?
comment:5 Changed 7 years ago by
| Owner: | changed from dante to Kitson Kelly |
|---|---|
| Status: | new → assigned |
comment:6 Changed 7 years ago by
could this pls. be applied to 1.9.0 ? Dojo Builder fails because of this problems
comment:7 Changed 7 years ago by
looking at the current CheckedMultiSelect?.css it seams that only formHighlight.png is not fixed
comment:8 Changed 7 years ago by
+1 for me on dojo 1.9.1. I use an @import statement on a .less file, and the loader complains with this error :
error(357) While optimizing a CSS file, it was impossible to compute the destination location of a relative URL.
CSS file: [...]mytheme.css; import: /[...]/js/src/dojox/form/resources/CheckedMultiSelect.css; relative URL: url("../../../dijit/themes/claro/form/images/formHighlight.png")
comment:9 Changed 6 years ago by
As of 1.9.2 this is still not fixed. In my case, it prevents our dojo-boilerplate-based project from compiling correctly.
Even if the correct replacement CSS needs hammering out, can we at least get the bad line removed?
comment:10 Changed 6 years ago by
Still not fixed in 1.10.1-pre
I'm forced to reapply the patch on each dojo upgrade...
comment:11 Changed 6 years ago by
| Milestone: | tbd → 1.10.1 |
|---|
I'll try to land this next week, if someone doesn't get to it first.
comment:16 Changed 6 years ago by
| Milestone: | 1.10.1 → 1.8.7 |
|---|---|
| Priority: | undecided → high |
| Resolution: | → fixed |
| Status: | assigned → closed |
Fixed and backported through 1.8.x
oops didn't mean to add peller