Declaration: bug using data-dojo-args attribute

[gorgoroth]

Using Declaration module to create a widget class declaratively and adding a dojo/method which accepts arguments, fails if arguments are defined using the data-dojo-args attribute. It works using the old args attribute.

This bug is caused by the buildRendering() method in Declaration.js which calls parser._functionFromScript() passing only the script but no the attrData.

A possible and simple solution could be to pass "data-dojo-" as the second argument to parser._functionFromScript() because Declaration seems to use general data-dojo-XXX attributes (particularly "data-dojo-event").

A better solution could be taking into account the parser scope name: so the Declaration module could, in some way, ask the parser the scope name and use it in his internal code and pass it to parser._functionFromScript(). This would allow to use custom HTML5 attributes with Declaration (es data-mywidget-args instead of data-dojo-args).

[bill]

In [29910]:

Fix data-dojo-args usage with Declaration, fixes #16303 !strict.

[bill]

Thanks, I did the simple fix for now.

As you said, Declaration is hardcoded to data-dojo-* attribute names. Scope is something that was needed for multi-version support, specifically for aliasing dojoType (dojo16Type vs dojo17Type). I don't see a reason to use scope in other attribute names like data-dojo-args. As an aside, I'm not sure scope is even important for dojoType, as that implies that one would run the 1.6 parser over the entire page, rather than just the section containing 1.6 widgets.

[bill]

#16998 is a duplicate of this ticket.