Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1630 closed defect (fixed)

validate color confusion

Reported by: Adam Peller Owned by: tk
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc: ktiedt@…
Blocked By: Blocking:

Description

I noticed that the validate tests no longer use red/green colors as they used to... except for the one widget which uses what's apparently a new method. (but uses red for valid and green for invalid; perhaps that should be flipped?)

Are the old docs on ValidationTextBox? no longer valid? Attributes like invalidColor which are documented to have defaults, etc.

Change History (5)

comment:1 Changed 13 years ago by tk

The colors are still the same... I copied them straight to new CSS classes... the one thats flipped is an example using a custom class prefix... the rest should all be the same still...

comment:2 Changed 13 years ago by tk

Cc: ktiedt@… added

comment:3 Changed 13 years ago by bill

Tk, didn't we already discuss this on chat? You said you were going to fix it. All the fields are showing up as white. Just compare http://archive.dojotoolkit.org/nightly/tests/widget/test_validate.html with http://archive.dojotoolkit.org/dojo-2006-09-01/tests/widget/test_validate.html . The difference should be obvious.

Also, you should mark in the test that the elevation field has custom colors, so people don't think it's a bug.

comment:4 Changed 13 years ago by tk

Resolution: fixed
Status: newclosed

Yes, I was looking into it, and found the problem... or rather didnt find it.. (I couldnt find my check in that modified Validate.js, or the files I committed with it...)

#6142 fixes this.

comment:5 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.