Opened 6 years ago
Closed 6 years ago
#16289 closed defect (fixed)
dojox/form/manager update tests to AMD, and make the test suite more comprehensive
| Reported by: | dylan | Owned by: | dylan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.9 |
| Component: | DojoX Form | Version: | 1.8.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
The test for dojox/form/manager is using legacy provide and require syntax, lots of dojo.* and dijit.* globals, and has other issues that do not promote best practices.
Also, the test suite is not very comprehensive, for example, it does not test the removal of observer events.
Change History (4)
comment:1 Changed 6 years ago by
| Status: | new → assigned |
|---|
comment:2 Changed 6 years ago by
Updates to related #16288 : test page updated, converted to AMD, and passing as of http://bugs.dojotoolkit.org/attachment/ticket/16288/patch_16288.5.diff
comment:4 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Landed, thanks @bitpshr for helping finish this one off. I'm closing it out.
Note: See
TracTickets for help on using
tickets.
Some work has been started in #16288