Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#16268 closed defect (fixed)

add back dojo.config.forceBgIframe flag

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.8.1
Keywords: Cc: Bryan Forbes
Blocked By: Blocking:

Description

[20187] added a dojo.config.forceBgIframe flag, but [20473] removed it, opting instead to create the iframe automatically in more cases.

However, sometimes the iframe is needed even on chrome and safari (on windows). I don't want to just add it unconditionally though because it will weigh things down, especially mobile.

So, should add back the flag (or a flag) to explicitly control whether or not there's an iframe.

Change History (7)

comment:1 Changed 7 years ago by bill

Cc: Bryan Forbes added
Milestone: tbd1.9
Status: newassigned

See also #11822.

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29907]:

Turn on BackgroundIframe for chrome too, to help with applets. Also add has() flag to control whether or not BackgroundIframe shows. Starting in 2.0 I'd like it to be false by default.

Fixes #11822, #16268 !strict.

comment:13 Changed 7 years ago by bill

In [30067]:

Rename bgIframe to config-bgIframe. Also moving BackgroundIframe test from dijit/general-modules to dijit/infrastructure-modules. Refs #16268 !strict.

comment:14 Changed 7 years ago by bill

In [30323]:

Backport of has("bgIframe") flag to 1.8 branch. Didn't change the default conditions when it's true though, so if you want to get the background iframe on Chrome then you need to manually set it, like test_bgIframe.html does. Refs #11822, #16268 !strict.

comment:14 Changed 7 years ago by bill

In [30324]:

Backport of has("bgIframe") flag to 1.7 branch. Didn't change the default conditions when it's true though, so if you want to get the

background iframe on Chrome then you need to manually set it, like test_bgIframe.html does. Refs #11822, #16268 !strict.

comment:15 Changed 6 years ago by Bill Keese <bill@…>

In 7a7961227df66de6fe483d81f582604f8bc518a3/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:15 Changed 6 years ago by Bill Keese <bill@…>

In 00dcee41b91ed27521105dd7da6c7fb7f71897bc/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.