Opened 7 years ago
Closed 7 years ago
#16261 closed defect (invalid)
[patch][ccla] JSON parsing tests should use strict parsing
Reported by: | andybalaam | Owned by: | andybalaam |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Core | Version: | 1.8.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Some of the tests in dojo/tests/json.js don't pass the "strict" flag to the JSON.parse function.
This flag has no effect in environments which provide a built-in JSON object.
In environments that fall back to the Dojo JSON parsing, this flag enables the safety check regular expression.
To ensure there are no bugs in this regular expression, we should pass strict=true to JSON.parse in all tests.
Andy Balaam (IBM, CCLA)
Attachments (1)
Change History (7)
Changed 7 years ago by
Attachment: | always-use-strict-mode-in-json-parsing-tests.patch added |
---|
comment:1 Changed 7 years ago by
Component: | TestFramework → Core |
---|---|
Owner: | set to Kris Zyp |
Status: | new → assigned |
The TestFramework category is for bugs in DOH itself, not for tests written using DOH.
comment:4 Changed 7 years ago by
We do have strict tests to that exercise the regular expressions (in older IE). If we made all the tests strict than we wouldn't be verifying the non-script code path would we?
comment:5 Changed 7 years ago by
Owner: | changed from Kris Zyp to andybalaam |
---|---|
Status: | assigned → pending |
comment:6 Changed 7 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
[patch][ccla] always-use-strict-mode-in-json-parsing-tests Andy Balaam (IBM, CCLA)