Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16260 closed defect (fixed)

TimeTextBox: text direction property does not affect time in dropdown

Reported by: hhelena Owned by: hhelena
Priority: undecided Milestone: 1.9
Component: Dijit - Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

When textDir of TimeTextBox? is set to "rtl", the time in dropdown popup is displayed with "ltr" text direction. Attached test file and screen shot

Attachments (3)

Bidi_Time TextBox.html​ (5.3 KB) - added by hhelena 7 years ago.
test file
timetextbox_textDir.png​ (28.0 KB) - added by hhelena 7 years ago.
Screen shot
16260.patch​ (516 bytes) - added by Douglas Hays 7 years ago.
patch from hhelena (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by hhelena

Attachment: Bidi_Time TextBox.html​ added

test file

Changed 7 years ago by hhelena

Attachment: timetextbox_textDir.png​ added

Screen shot

comment:1 Changed 7 years ago by Douglas Hays

Owner: changed from Douglas Hays to hhelena
Status: new → pending

helena, _TimePicker has not been instrumented for textDir. Please submit a patch.

Changed 7 years ago by Douglas Hays

Attachment: 16260.patch​ added

patch from hhelena (IBM, CCLA)

comment:2 Changed 7 years ago by Douglas Hays

After applying the patch, the _TimePicker menu is incorrectly following the GUI direction and not the textDir attribute.

comment:3 Changed 7 years ago by Douglas Hays

Resolution: → fixed
Status: pending → closed

In [29933]:

Fixes #16260. Add textDir to timepicker popup constructor. Add automated tests.

comment:4 Changed 7 years ago by Douglas Hays

Milestone: tbd → 1.9
Note: See TracTickets for help on using tickets.