Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16259 closed defect (fixed)

Select: text direction property affects GUI orientation of widget

Reported by: hhelena Owned by: Douglas Hays
Priority: undecided Milestone: 1.9
Component: Dijit - Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

When use Select with textDir= "rtl", the arrow is displayed on the left side, as it is expected when dir="rtl". When use Select with dir="rtl" and textDir= "ltr", the arrow is displayed on the right side, as it is expected when dir="ltr". Attached a test file and screen shot

Attachments (3)

Bidi_Select.html (6.9 KB) - added by hhelena 7 years ago.
test file
select_textDir.png (25.2 KB) - added by hhelena 7 years ago.
Screen shot
16259.patch (1.4 KB) - added by Douglas Hays 7 years ago.
partial fix from hhelena (IBM, CCLA)

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by hhelena

Attachment: Bidi_Select.html added

test file

Changed 7 years ago by hhelena

Attachment: select_textDir.png added

Screen shot

comment:1 Changed 7 years ago by Douglas Hays

Cc: HKatory@… added
Owner: changed from Douglas Hays to hhelena
Status: newpending

helena/hossam, it doesn't look like Select has been instrumented for textDir support. Please provide a patch.

Changed 7 years ago by Douglas Hays

Attachment: 16259.patch added

partial fix from hhelena (IBM, CCLA)

comment:2 Changed 7 years ago by Douglas Hays

After applying the patch, text is being aligned with the GUI direction and not the textDir attribute.

comment:3 Changed 7 years ago by Douglas Hays

Cc: HKatory@… removed
Milestone: tbd1.9
Owner: changed from hhelena to Douglas Hays
Status: pendingassigned

From Tomer Mahlin,
In Select widget the input field is NOT editable and to the best of our understanding it is not possible to turn it into editable. In such contexts (we call them static) the alignment should follow GUI direction

comment:4 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29931]:

Fixes #16259. Add textDirNode attach point to Select template so that GUI direction is adhered to.

comment:5 Changed 7 years ago by Douglas Hays

In [29934]:

Refs #16259. Fix Bidi select test.

Note: See TracTickets for help on using tickets.