#16250 closed defect (fixed)
IE10 / FF16: uncomment linear-gradient lines in claro/variables.less linear-gradient mixins
Reported by: | Kenneth G. Franqueiro | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.8.2 |
Component: | Dijit - LnF | Version: | 1.8.1 |
Keywords: | ie10 | Cc: | |
Blocked By: | Blocking: |
Description
Currently in claro/variables.less, there are lines for the standard (non-vendor-prefixed) linear-gradient property, but they are commented out presumably with the thought that it wasn't approved and no browsers supported the property prefix-less at the time.
However, IE10 *does* support the property prefix-less, as does FF16. Therefore, we should not only uncomment the prefix-less rules, but also likely remove the -ms-linear-gradient lines, since there's no need for it (IE9 doesn't support it, and IE10 supports it sans prefix).
Change History (7)
comment:1 Changed 8 years ago by
Keywords: | ie10 added |
---|---|
Milestone: | tbd → 1.8.2 |
Priority: | undecided → high |
comment:2 Changed 8 years ago by
Agreed. I wish FF10 supported it too but surely it doesn't, so I guess we need to leave the -moz-linear-gradient rules in there for a while.
And from your lack of comments about webkit, I guess that safari and chrome don't support the new standard yet?
comment:5 Changed 8 years ago by
RE comment:2, that's correct, according to MDN and caniuse:
- https://developer.mozilla.org/en-US/docs/CSS/linear-gradient#Browser_compatibility
- http://caniuse.com/#feat=css-gradients
Note that the table on MDN also notes basic support even in FF 3.6, and Dojo 1.x still supports that as well, so -moz should stay in for that as well as FF10.
Thanks for committing the fixes.
FWIW, I noticed just now that MDN mentions -ms- is technically required if you want to specifically support the IE10 platform previews and consumer preview, but it should be a moot point for IE10 final, and I wouldn't see much point in bloating our CSS just to support beta/preview versions of a browser.
comment:6 Changed 8 years ago by
Actually the non-prefix version is working for me in IE10 (ie Windows 8) preview release.
Looks like we can get rid of -o-linear-gradient pretty soon too. And I bet Safari and Webkit will come around before the release of Dojo 1.9.
comment:7 Changed 8 years ago by
Note that this isn't applicable to 1.7 and earlier because they use actual background images for the gradients, rather than CSS gradients.
Marking for 1.8.2 for IE10 support; adding ie10 keyword to hopefully make it stand out more for further backports.