[patch][cla][pr] IE9 display a error "Object doesn't support this action" at the following location doc.readyState = "complete" in 1.8 dojo.js

[midway500]

windowOnLoadListener = domOn(window, "load", "onload", function(){
	req.pageLoaded = 1;
	doc.readyState!="complete" && (doc.readyState = "complete");
	windowOnLoadListener();
});

[bill]

Please attach a test case using the "attach file" button. It should be as small as possible to still reproduce the problem, almost always a single HTML file that we can load in the browser and use to reproduce then problem.

Then, give exact instructions on how to reproduce the problem using your attached test file.

The test case is necessary both to confirm that there's a bug, and for us to be able to debug the problem.

Thanks!

[midway500]

I have not have a chance to crate a test case yet but a quick search of dojo.js indicates that doc is alias for window.document and doc.readyState is a read-only attribute and IE 9 does not like modification to the read-only attribute.

Further inspect at the statement seems to me that it does not do anything useful as it tries to set a read-only attribute. Might be that statement is not necessary at all. I might be wrong as I don't know the whole context of the function. I will create a test case as soon as I have a chance. Thx.

[bill]

Yes, setting doc.readyState does look suspicious. It's from Rawld in [25545].

[Rawld Gill]

This code is fragile with all the browsers we're trying to support. Feel free to reopen if you can provide a small test to show the problem.

[tommi_v]

Main file for reproduce

[tommi_v]

Inline frame for reproduce

[tommi_v]

Actually, I don't get why you need test case, it's pretty easy to check if this property readonly in IE < 9, and it's obvious that code will always fail if it reach branch when readyState != "complete". Fine, if you need test files - it's attached. Open main file and wait one sec while inline frame reload itself. Also someone, please re-open ticket, looks like I have no right to do it.

[D4nR0ux]

The problem occurs with dojo 1.9.2. It is sporadic and difficult to reproduce. To bypass the problem, I changed in my environment the function in file dojo.js to catch the exception:

windowOnLoadListener = domOn(window, "load", "onload", function(){

req.pageLoaded = 1; try{doc.readyState != "complete" && (doc.readyState = "complete");}catch(ex){}; windowOnLoadListener();

});

[jmaner]

Any update on this bug?? It's 3 years old and the last comment was 15 months ago. Our product needs this fix.

[dylan]

PR needs review at ​https://github.com/dojo/dojo/pull/199 .

[Rawld Gill]

doc.readyState = "complete" is executed iff doc.readyState != "complete", which will be true for browsers with bugs setting doc.readyState. Historically, the only browser with this problem is FF<=3.5...which is long gone.

I was unable to dup the bug on browserstack with the provided examples on IE 7,8 on XP and 8-10 on Win7. I would be very interested to know the value of doc.readyState when this bug shows on IE.

The proposed patch (​​https://github.com/dojo/dojo/pull/199) looks fine, though it will not fix the apparently broken browser thereby possibly causing dojo/domReady to fail, it will certainly squelch bug without doing further harm.

[Dylan Schiemann <dylan@…>]

In a275e823/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <dylan@…>]

In 37e8256/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <dylan@…>]

In 430df9b/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Dylan Schiemann <dylan@…>]

In 16686d6/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?