#16245 closed task (fixed)
[PATCH][CCLA] dijit.layout clean up layout test pages for accessibility
| Reported by: | mikeb | Owned by: | bill |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.8.4 |
| Component: | Dijit | Version: | 1.8.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Update all of the layout test pages (except those in the /robot/ folder) to be more accessible. This will help for accessibility regression testing in the future. Most of the changes were adding lang=en to <html>, role=main to <body>, and adding appropriate aria-label or <label>s.
Attachments (2)
Change History (7)
Changed 8 years ago by
| Attachment: | layout-tests-a11y.patch added |
|---|
comment:1 Changed 8 years ago by
| Milestone: | tbd → 1.9 |
|---|
OK, thanks. I went over your changes and fixed a few missing closing angle brackets. FYI, webstorm still complains about the <input> tags with aria-label attributes; it wants a real <label> node.
Changed 8 years ago by
| Attachment: | 29882-backport.patch added |
|---|
Backport of #16245 to 1.8 branch for accessibility, please proxy commit for Mike BIllau CCLA on file
comment:3 Changed 8 years ago by
Hello, would it be possible to backport these test page fixes to 1.8? This would make it easier to do accessibility verification testing on 1.8 branch as well as make it easier to backport some other a11y fixes. I created 29882-backport.patch for this. Thanks.
comment:4 Changed 8 years ago by
| Milestone: | 1.9 → 1.8.4 |
|---|---|
| Type: | defect → task |
Sure, since they are test fixes we don't have to worry about destabilizing the release. I'll check in your fixes after rerunning the regression.
update of the dijit/tests/layout test pages for accessibility, please proxy commit for Michael Billau CCLA on file with IBM