Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16241 closed defect (fixed)

[PATCH][CCLA] dijit.layout.ContentPane : remove invalid aria role

Reported by: mikeb Owned by: bill
Priority: undecided Milestone: 1.8.4
Component: Dijit Version: 1.8.1
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description

As per the WAI-ARIA spec about role=group (http://www.w3.org/TR/wai-aria/roles#group) we should remove role=group from the ContentPane?.

"There are very few scenarios where group is appropriate outside of a tree. One example might be a group of form elements or widgets that are all related to the same subject and thus share a common description. In this case, the group may not only have aria-labeledby but also aria-describedby. In all cases where group is outside of a tree, it should have either aria-label or aria-labeledby. In most cases, if there is not a labeling element on the screen that can be referenced by aria-labelledby, then you probably should not be using group." - an accessibility expert who sits on the w3 working group

I attached a patch for this issue. I will attach the fixes for the all of the layout test pages in a single, separate ticket.

Attachments (2)

ContentPane.js.remove.invalid.role.patch (514 bytes) - added by mikeb 7 years ago.
remove role=group from dijit.layout.ContentPane?, please proxy commit for Michael Billau CCLA on file with IBM
backport-ticket-16241-contentPane-accessibility-fixes.patch (503 bytes) - added by mikeb 7 years ago.
Backport accessibility fix to ContentPane? from 30198, refs 16241, please proxy commit for Michael Billau

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by mikeb

remove role=group from dijit.layout.ContentPane?, please proxy commit for Michael Billau CCLA on file with IBM

comment:1 Changed 7 years ago by bill

Cc: Becky Gibson added
Milestone: tbd1.9

I'll remove, but CC'ing Becky since she added that code in [12280].

Version 0, edited 7 years ago by bill (next)

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: newclosed

In [29883]:

Remove role=group default group setting. It usually shouldn't be there. Patch from Mike Billau (IBM, CCLA), thanks. Fixes #16241 !strict.

comment:3 Changed 7 years ago by Becky Gibson

Thanks for cc'ing me. I have no objections to removing. Many of the aria attributes were added in order to make JAWS work before the ARIA spec was finalized and before JAWS had full support. There are probably other cases where there are aria attributes which are not officially allowed by the spec. They should get found over time and ferreted out.

comment:4 Changed 7 years ago by mikeb

Would it be possible to backport this to 1.8 branch? I created a patch that just uses [29883]. There have been additional changes to ContentPane?, but they were already backported to 1.8 in [30197].

Changed 7 years ago by mikeb

Backport accessibility fix to ContentPane? from 30198, refs 16241, please proxy commit for Michael Billau

comment:5 Changed 7 years ago by bill

This seems safe to backport.

comment:6 Changed 7 years ago by Douglas Hays

In [30313]:

Refs #16241. Backport [29883] to 1.8. !strict

comment:7 Changed 7 years ago by Douglas Hays

Milestone: 1.91.8.4
Note: See TracTickets for help on using tickets.