[patch][cla] dojox/analytics throws a leave page/stay on the same page error on chrome

[dylan]

the dojox/analytics/tests/test_analytics.html page will throw the following dialog when clicking on the links:

[object Object]

Are you sure you want to leave this page?

This appears to be related to how we return a promise, and how we handle this promise in checkData and pushData, and finally the call to unload.addOnUnload(this, "pushData", true);

We can either change pushData to not return a promise, and use a reference to the promise, or we could bind something different to the unload handler that doesn't use a promise.

[dylan]

Patch file that stops returning a promise to address Google Analytics issue

[dylan]

Added a patch against trunk. This needs a review. While this works, I'm not sure this is ideal.

[Kenneth G. Franqueiro]

I'm no expert with this code, but I'm wondering why handleAs: "json" was added to the requests - seems like that could be changing behavior, and is unrelated to the fix? IIUC the focus of the fix is the introduction of promiseRef instead of returning a promise from pushData (which is what's causing the popup message, since pushData is hooked on onbeforeunload).

Also, you can remove the now-commented old return statements, no sense keeping them there.

[Kenneth G. Franqueiro]

Much simpler and more isolated patch

[dylan]

In [29953]:

refs #16233, fixes analytics issue in chrome

[dylan]

Ken's patch passes tests and is much simpler, I've committed to trunk. Will also backport to 1.8.x.

[dylan]

In [29954]:

fixes #16233