#16224 closed defect (fixed)
Toaster widget creates excessive this.connects
| Reported by: | Karl Tiedt | Owned by: | Karl Tiedt |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.11 |
| Component: | DojoX Widgets | Version: | 1.8.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
While they do get cleaned up when the toaster is destroyed, these connections are only relevant for the life of the message being displayed... so memory usage will continue climbing needlessly.
Attachments (1)
Change History (6)
comment:1 Changed 8 years ago by
| Owner: | changed from dante to Karl Tiedt |
|---|---|
| Status: | new → assigned |
comment:2 follow-up: 3 Changed 6 years ago by
| Milestone: | tbd → 1.8.11 |
|---|
I started to clean-up Toaster in https://github.com/dojo/dojox/pull/192
ktiedt, any interest in helping out with this?
comment:3 Changed 6 years ago by
Replying to dylan:
I started to clean-up Toaster in https://github.com/dojo/dojox/pull/192
ktiedt, any interest in helping out with this?
Wow, trip down memory lane, I am honestly surprised I never addressed this before. I can most likely take a look this weekend. Is there an imminent deadline coming up (just incase tomorrow falls through)?
comment:4 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 Changed 6 years ago by
| Milestone: | 1.8.11 → 1.11 |
|---|
Does not cleanly backport, so leaving as 1.11.
Note: See
TracTickets for help on using
tickets.
I'll go ahead and fix this in a few days (will also be updating my other previous ticket for 1.8 branch)