Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#16224 closed defect (fixed)

Toaster widget creates excessive this.connects

Reported by: Karl Tiedt Owned by: Karl Tiedt
Priority: undecided Milestone: 1.11
Component: DojoX Widgets Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

While they do get cleaned up when the toaster is destroyed, these connections are only relevant for the life of the message being displayed... so memory usage will continue climbing needlessly.

Attachments (1)

toaster.diff (1.7 KB) - added by Karl Tiedt 4 years ago.
Diff against PR from Dylan

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Karl Tiedt

Owner: changed from dante to Karl Tiedt
Status: newassigned

I'll go ahead and fix this in a few days (will also be updating my other previous ticket for 1.8 branch)

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.8.11

I started to clean-up Toaster in https://github.com/dojo/dojox/pull/192

ktiedt, any interest in helping out with this?

comment:3 in reply to:  2 Changed 4 years ago by Karl Tiedt

Replying to dylan:

I started to clean-up Toaster in https://github.com/dojo/dojox/pull/192

ktiedt, any interest in helping out with this?

Wow, trip down memory lane, I am honestly surprised I never addressed this before. I can most likely take a look this weekend. Is there an imminent deadline coming up (just incase tomorrow falls through)?

Changed 4 years ago by Karl Tiedt

Attachment: toaster.diff added

Diff against PR from Dylan

comment:4 Changed 4 years ago by dylans <dylan@…>

Resolution: fixed
Status: assignedclosed

In 56ee55d6b240de0b921f4ec200bd3e08951cbdcc/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 4 years ago by dylan

Milestone: 1.8.111.11

Does not cleanly backport, so leaving as 1.11.

Note: See TracTickets for help on using tickets.