Opened 7 years ago

Closed 6 years ago

#16220 closed defect (fixed)

loader config map star entry does not work

Reported by: Rawld Gill Owned by: Rawld Gill
Priority: blocker Milestone: 1.8.2
Component: Loader Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

For example, the loader will not consume the * entry in the following map:

map:{
	'my/Dialog':{'dijit/Dialog':'dijit/Dialog'},
	'*':{'dijit/Dialog':'my/Dialog'}
},

Change History (6)

comment:1 Changed 7 years ago by Rawld Gill

Milestone: tbd1.8.2
Priority: undecidedhigh
Status: newassigned

comment:2 Changed 6 years ago by Brandon Payton

This bug was mentioned in a recent dojo-meeting, and it sounded like some background was needed. SitePen? recently did some work for my employer and used a combination of loader config paths and aliases to use patched dijit modules in some cases. This approach worked fine for an unbuilt version, but IIRC, the Dojo build system wasn't able to properly detect all dependencies. SitePen? support suggested we use a loader map instead and said we needed to tweak the 1.8.0 version of dojo.js.
Changing this:

if(item[0]=="*"){
    mapProgs.star = item[1];
}

To this:

if(item[0]=="*"){
    mapProgs.star = item;
}

comment:3 Changed 6 years ago by Colin Snover

Priority: highblocker

comment:4 Changed 6 years ago by Colin Snover

If this is indeed a one line fix (and from our internal ticket it looks like it is) then it needs to get into 1.8.2. Your call if you do it or I do. :)

comment:5 Changed 6 years ago by Rawld Gill

In [30129]:

fixed type; refs #16220; !strict

comment:6 Changed 6 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [30130]:

fixed typo; fixes #16220; !strict

Note: See TracTickets for help on using tickets.