loader config map star entry does not work

[Rawld Gill]

For example, the loader will not consume the * entry in the following map:

map:{
	'my/Dialog':{'dijit/Dialog':'dijit/Dialog'},
	'*':{'dijit/Dialog':'my/Dialog'}
},

[Brandon Payton]

This bug was mentioned in a recent dojo-meeting, and it sounded like some background was needed. SitePen? recently did some work for my employer and used a combination of loader config paths and aliases to use patched dijit modules in some cases. This approach worked fine for an unbuilt version, but IIRC, the Dojo build system wasn't able to properly detect all dependencies. SitePen? support suggested we use a loader map instead and said we needed to tweak the 1.8.0 version of dojo.js.
Changing this:

if(item[0]=="*"){
    mapProgs.star = item[1];
}

To this:

if(item[0]=="*"){
    mapProgs.star = item;
}

[Colin Snover]

If this is indeed a one line fix (and from our internal ticket it looks like it is) then it needs to get into 1.8.2. Your call if you do it or I do. :)

[Rawld Gill]

In [30129]:

fixed type; refs #16220; !strict

[Rawld Gill]

In [30130]:

fixed typo; fixes #16220; !strict