dojo/data/ObjectStore save function

[cyril.dupetit]

In the save function, when calling the onComplete function Callback, it must be better to pass the "value" args than the "actions" variable. The variable "actions" is not used in the function "save".

line 456 : kwArgs.onComplete.call(kwArgs.scope, actions value);

Deferred.when(result, function(value){
	if(!(--left)){
		if(kwArgs.onComplete){
-->			kwArgs.onComplete.call(kwArgs.scope, actions); <--
		}
	}
},function(value){
	// on an error we want to revert, first we want to separate any changes that were made since the commit
	left = -1; // first make sure that success isn't called
	kwArgs.onError.call(kwArgs.scope, value);
});

Thx Regards

[dylan]

Created a pull request at ​https://github.com/dojo/dojo/pull/163 . Sorry it took 3 years to get around to it...

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

[dylan]

PR needs an update per comments in PR, so moving to 1.13.

[dylan]

Revised PR at ​https://github.com/dojo/dojo/pull/250/