Opened 8 years ago
Last modified 3 years ago
#16218 assigned defect
dojo/data/ObjectStore save function
Reported by: | cyril.dupetit | Owned by: | dylan |
---|---|---|---|
Priority: | low | Milestone: | 1.14 |
Component: | Data | Version: | 1.8.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
In the save function, when calling the onComplete function Callback, it must be better to pass the "value" args than the "actions" variable. The variable "actions" is not used in the function "save".
line 456 : kwArgs.onComplete.call(kwArgs.scope, actions value);
Deferred.when(result, function(value){ if(!(--left)){ if(kwArgs.onComplete){ --> kwArgs.onComplete.call(kwArgs.scope, actions); <-- } } },function(value){ // on an error we want to revert, first we want to separate any changes that were made since the commit left = -1; // first make sure that success isn't called kwArgs.onError.call(kwArgs.scope, value); });
Thx Regards
Change History (8)
comment:1 Changed 6 years ago by
Milestone: | tbd → 1.11 |
---|---|
Owner: | changed from Kris Zyp to dylan |
Priority: | undecided → low |
Status: | new → assigned |
comment:2 Changed 5 years ago by
comment:3 Changed 5 years ago by
Milestone: | 1.11 → 1.12 |
---|
comment:4 Changed 4 years ago by
Milestone: | 1.13 → 1.15 |
---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
comment:5 Changed 4 years ago by
Milestone: | 1.15 → 1.12 |
---|
comment:6 Changed 4 years ago by
Milestone: | 1.12 → 1.13 |
---|
PR needs an update per comments in PR, so moving to 1.13.
comment:8 Changed 3 years ago by
Milestone: | 1.13 → 1.14 |
---|
Note: See
TracTickets for help on using
tickets.
Created a pull request at https://github.com/dojo/dojo/pull/163 . Sorry it took 3 years to get around to it...