Opened 8 years ago
Closed 8 years ago
#16205 closed defect (wontfix)
_WidgetBase.js - isLeftToRight needs to use this.dir.toLowerCase() (Safari)
Reported by: | barbossusus | Owned by: | |
---|---|---|---|
Priority: | undecided | Milestone: | tbd |
Component: | Dijit | Version: | 1.7.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Setting the dir constructor argument to "LTR" or "RTL" in ComboBox/FilteringSelect? does not take effect because isLeftToRight function in _WidgetBase.js should look something like this:
... isLeftToRight: function(){ // summary: // Return this widget's explicit or implicit orientation (true for LTR, false for RTL) // tags: // protected return this.dir ? (this.dir.toLowerCase() == "ltr") : domGeometry.isBodyLtr(); //Boolean },
...
This behavior could be observed in Safari if widgets are instantiated declaratively using capital letters.
Change History (1)
comment:1 Changed 8 years ago by
Component: | General → Dijit |
---|---|
Resolution: | → wontfix |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
It's true that setting dir to "LTR" or "RTL" doesn't work, but that's because "LTR" and "RTL" are invalid values for dir. It's documented as being either "ltr" or "rtl":
There are many cases throughout dijit where it assumes that dir is lowercase, such as this code from _BidiSupport.js:
And of course, there are many other cases throughout dijit and other software where settings are case sensitive. So, I don't think it's worth supporting case sensitivity for this one property.