Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#162 closed defect (fixed)

[patch] Dialog widget doesn't work when page margins are not specified in pixels

Reported by: eugene@… Owned by: alex
Priority: high Milestone:
Component: Widgets Version: 0.1
Keywords: Cc:
Blocked By: Blocking:

Description

1) If you specify page margins in em or %, dialog widget fails because it calculates background width in pixels now (previous value of 100% didn't work in IE6 because it doesn't take into account page margins => was off-center and didn't cover everything). This effect was found with IE6.

2) Background width was calculated just once => if window was resized, then background was off.

The attached patch fixes these problems. It was tested with IE6, FF, and Opera 8.50.

Existing code and this patch share one problem: if window is resized after dialog was opened, it still looks strange. The comprehensive solution is to track window resize adjusting background (and possibly dialog box position) dynamically. I don't know if it's worth it to fix now.

Attachments (1)

dojo.dialog.patch (708 bytes) - added by eugene@… 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by eugene@…

Attachment: dojo.dialog.patch added

comment:1 Changed 14 years ago by alex

Milestone: 0.2release

comment:2 Changed 14 years ago by alex

Owner: changed from anonymous to david

comment:3 Changed 14 years ago by alex

Owner: changed from david to alex
Status: newassigned

stealing from David since he hasn't applied.

comment:4 Changed 14 years ago by alex

Resolution: fixed
Status: assignedclosed

Having looked at the patch, it appears that previous changes to the widget have included analogous fixes. Closing.

Thanks to David and Eugene for getting this widget into good shape.

comment:5 Changed 12 years ago by (none)

Milestone: 0.2release

Milestone 0.2release deleted

Note: See TracTickets for help on using tickets.