#162 closed defect (fixed)
[patch] Dialog widget doesn't work when page margins are not specified in pixels
| Reported by: | Owned by: | alex | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Widgets | Version: | 0.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
1) If you specify page margins in em or %, dialog widget fails because it calculates background width in pixels now (previous value of 100% didn't work in IE6 because it doesn't take into account page margins => was off-center and didn't cover everything). This effect was found with IE6.
2) Background width was calculated just once => if window was resized, then background was off.
The attached patch fixes these problems. It was tested with IE6, FF, and Opera 8.50.
Existing code and this patch share one problem: if window is resized after dialog was opened, it still looks strange. The comprehensive solution is to track window resize adjusting background (and possibly dialog box position) dynamically. I don't know if it's worth it to fix now.
Attachments (1)
Change History (6)
Changed 14 years ago by
| Attachment: | dojo.dialog.patch added |
|---|
comment:1 Changed 14 years ago by
| Milestone: | → 0.2release |
|---|
comment:2 Changed 14 years ago by
| Owner: | changed from anonymous to david |
|---|
comment:3 Changed 14 years ago by
| Owner: | changed from david to alex |
|---|---|
| Status: | new → assigned |
comment:4 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Having looked at the patch, it appears that previous changes to the widget have included analogous fixes. Closing.
Thanks to David and Eugene for getting this widget into good shape.
stealing from David since he hasn't applied.