Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#16194 closed defect (fixed)

dijit.form.DateTextBox executes validator property function during construction

Reported by: scott.a.jenkins Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.7
Component: Dijit - Form Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

The following code fragment demonstrates, at least in IE9, dijit.form.DateTextbox? executes the validator during construction; simply changing this code to TextBox? does NOT execute the validator during construction.

function test() {
    var neverUsed = new dijit.form.DateTextBox({
        validator:
            function () {
                console.log('executing the validator during construction');
            }
    });
}

Attachments (1)

16194.patch (63.8 KB) - added by Douglas Hays 7 years ago.
fix

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by scott.a.jenkins

Tested in 1.8, google CDN does not yet have 1.8.1.

Changed 7 years ago by Douglas Hays

Attachment: 16194.patch added

fix

comment:2 Changed 7 years ago by Douglas Hays

Milestone: tbd1.9
Status: newassigned

comment:3 Changed 7 years ago by haysmark

I ran the form tests in IE10 and they passed with this change.

comment:4 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [29878]:

Fixes #16194. Don't call validate() until _created==true. Refactored non-robot tests and added test event handlers where there were race conditions before causing spurious test failures.

comment:5 Changed 5 years ago by Bill Keese <bill@…>

In 040283a3c5b60c3f42cfa53e6996ab3bc7da86e2/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by bill

Milestone: 1.91.8.7
Note: See TracTickets for help on using tickets.