Opened 10 years ago

Closed 8 years ago

#16192 closed defect (patchwelcome)

AlwaysShowToolbar plugin breaks ViewSource & FindReplace plugins

Reported by: Matt Lauer Owned by:
Priority: undecided Milestone: tbd
Component: Editor Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:


It breaks the ViewSource? plugin: Go here:

  1. Click the ViewSource? button to enter source mode. You cannot get back out. It seems to die within line 315 or 316 of ViewSource?.js as far as I can tell.

It breaks the Editor's height via the FindReplace? plugin: Go here:

  1. Click the FindReplace? magnifying glass button to add another toolbar to the Editor.
  2. Add a couple paragraphs to the body and watch the Editor's container and the green div get overlapped because they were both set a fixed height that isn't updated when Editor resizes.

When ViewSource? exits normally, it also suffers from the same problem as FindReplace? where the 2 parent containers have fixed heights and they shouldn't.

The AlwaysShowToolbar? is a very useful for editing large sections of HTML which are mostly text. It shouldn't break the Editor (and other plugins) when it is used.

Also, please see for another AlwaysShowToolbar? bug. This one cuts off text at the bottom of equal to the height of the Toolbar.

Change History (1)

comment:1 Changed 8 years ago by bill

Resolution: patchwelcome
Status: newclosed

Unlikely this will be fixed unless someone wants to supply a patch (including a test case).

Note: See TracTickets for help on using tickets.