Opened 7 years ago

Closed 4 years ago

#16184 closed feature (patchwelcome)

Allow using deviceTheme as an AMD plugin

Reported by: Eric Durocher Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.13
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently the recommended way to use dojox/mobile/deviceTheme is to load it in a <script> tag. It would be more consistent to be able to use it as a regular AMD module. A solution for this is to make deviceTheme an AMD plugin, so adding "dojox/mobile/deviceTheme!" in the require list would wait for all CSS of the theme to be loaded.

Change History (5)

comment:1 Changed 7 years ago by Eric Durocher

Milestone: tbd1.9

comment:2 Changed 7 years ago by cjolif

Milestone: 1.92.0

comment:3 Changed 7 years ago by Eric Durocher

Since we support browsers that do not implement onload/onerror on <link> tags (Android 2/3), implementing this would require a reliable cross-browser css! plugin first, see #5402. So, moving this to 2.0 seems more realistic.

comment:4 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:5 Changed 4 years ago by dylan

Milestone: 2.01.12
Resolution: patchwelcome
Status: assignedclosed

Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.