Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16183 closed enhancement (fixed)

Allow use of _TemplatedMixin in mobile widgets subclasses

Reported by: Eric Durocher Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Users may want to customize mobile widgets using dijit templates. The goal of this ticket is to make sure this is possible, i.e. the correct calls are done so that the template will be instantiated, etc.

Attachments (1)

patch16183.patch (63.5 KB) - added by Adrian Vasiliu 7 years ago.
Allow templating of some widgets - Adrian Vasiliu (IBM, CCLA)

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Eric Durocher

Milestone: tbd1.9

comment:2 Changed 7 years ago by Eric Durocher

Owner: changed from Eric Durocher to Adrian Vasiliu
Status: newassigned

comment:3 Changed 7 years ago by Peter Svensson

The lack of custom widgets in dojox.mobile has been a major factor for me using regular Dojo instead, when making a Mobile client for customers.

It would be great to be able to have completely modular custom widgets on mobile too, and not have to rely on jQuery'esque queries for parts of a page, so here's a bump to up the prio on this one :)

comment:4 Changed 7 years ago by Adrian Vasiliu

The attached patch adds support for templating of ListItem, Heading, CheckBox, and Slider. It includes a test/demo (dojox/mobile/tests/test_Templated-widgets.html).

This is a preliminary variant, to allow collecting feedback. Support for templating a few other widgets may be added (and a DOH will be added for sure).

comment:5 Changed 7 years ago by nickmaynard

+1 here. Particularly for subclassing _View. On our projects, we have monkey patched _View using dojo/aspect to enable this function, as otherwise View.buildRendering() clobbers it.

Last edited 7 years ago by nickmaynard (previous) (diff)

comment:6 Changed 7 years ago by Adrian Vasiliu

Updated the patch to add the templatization of View, Switch, and RadioButton.

comment:7 Changed 7 years ago by Adrian Vasiliu

Updated the patch again to add various fixes and improvements. Also added a DOH test.

Changed 7 years ago by Adrian Vasiliu

Attachment: patch16183.patch added

Allow templating of some widgets - Adrian Vasiliu (IBM, CCLA)

comment:8 Changed 7 years ago by cjolif

In [30591]:

refs #16183. Implement the ability to add templating behavior to a subset of mobile widgets (without forcing _TemplatedMixin inheritance). Thanks Adrian Vasiliu (IBM, CCLA). !strict.

comment:9 Changed 7 years ago by cjolif

Will be closed once added to release notes & documented.

comment:10 Changed 7 years ago by Adrian Vasiliu

comment:11 Changed 7 years ago by cjolif

Resolution: fixed
Status: assignedclosed

comment:12 Changed 7 years ago by Adrian Vasiliu

In [31436]:

refs #16183. Avoid use of alert() and some ergonomy/cosmetic improvements.

comment:13 Changed 7 years ago by Adrian Vasiliu

In [31437]:

refs #16183. Avoid use of alert() and some ergonomy/cosmetic improvements.

Note: See TracTickets for help on using tickets.