Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#16182 closed enhancement (fixed)

Check/cleanup Stateful API in mobile widgets

Reported by: Eric Durocher Owned by: Adrian Vasiliu
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc: Ed Chatelain
Blocked By: Blocking:

Description

Some mobile widgets do not fully comply with the Stateful APIS:

  • some attributes can be set only in markup or at instantiation and cannot be changed dynamically, for example #16133
  • some widgets do not comply with the Stateful API, for example SpinWheelSlot? has setValue()/getValue() methods, these should be set/get("value") and should call _set to correctly notify, etc

Attachments (2)

patch16182.patch​ (17.9 KB) - added by Adrian Vasiliu 6 years ago.
Documents properties that cannot be set after creation, and other doc improvements. - Adrian Vasiliu (IBM, CCLA)
patch16182-diff.patch​ (11.7 KB) - added by Adrian Vasiliu 6 years ago.
Added [const] API doc flags plus fixes of a few old doc errors.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Eric Durocher

Milestone: tbd → 1.9

comment:2 Changed 7 years ago by Eric Durocher

Owner: changed from Eric Durocher to Adrian Vasiliu
Status: new → assigned

comment:3 Changed 6 years ago by Ed Chatelain

Cc: Ed Chatelain added

comment:4 Changed 6 years ago by Adrian Vasiliu

Resolved tickets in this area:

New:

  • #16133 "dojox.mobile.ListItem set clickable after xhr request"
  • #16349 "dojox/mobile/Heading does not apply href or transition to backButton"
  • The patch attached to this ticket (documentation).

Older, already committed since 1.8:

  • #16275 "Heading now supports setting the moveTo after construction."
  • #16164 "some properties of subclasses of _ItemBase cannot be set before completion of startup."
  • #16314 "Now ListItem supports setting the busy property to false before being set to true"

Concerning SpinWheelSlot's setValue/getValue: this is solved in 1.8 already (#14807).

Last edited 6 years ago by Adrian Vasiliu (previous) (diff)

comment:5 Changed 6 years ago by cjolif

Summary: Check/cleanup Statful API in mobile widgets → Check/cleanup Stateful API in mobile widgets

comment:6 Changed 6 years ago by cjolif

Resolution: → fixed
Status: assigned → closed

In [30776]:

fixes #16182. Documents properties that cannot be set after creation, and other doc improvements. Thanks Adrian Vasiliu (IBM, CCLA). !strict

comment:7 Changed 6 years ago by bill

Actually, this should be done with the [const] flag, like for dropDownPosition in _HasDropDown.js. Admittedly that's ​not showing up in the API guide yet.

Last edited 6 years ago by bill (previous) (diff)

comment:8 Changed 6 years ago by cjolif

I guess the priority is lower priority as this is not showing up in the doc anyway, but Adrian if you come up with a patch that add [const] as well I will commit it.

Changed 6 years ago by Adrian Vasiliu

Attachment: patch16182.patch​ added

Documents properties that cannot be set after creation, and other doc improvements. - Adrian Vasiliu (IBM, CCLA)

comment:9 Changed 6 years ago by Adrian Vasiliu

Uploaded a new version adding the [const], plus a few fixes of old doc errors I noticed with this occasion.

Changed 6 years ago by Adrian Vasiliu

Attachment: patch16182-diff.patch​ added

Added [const] API doc flags plus fixes of a few old doc errors.

comment:10 Changed 6 years ago by cjolif

In [30783]:

refs #16182. Added [const] API doc flags plus fixes of a few old doc errors. Thanks Adrian Vasiliu (IBM, CCLA). !strict.

Note: See TracTickets for help on using tickets.