Opened 7 years ago
Closed 6 years ago
#16180 closed enhancement (fixed)
Improve Custom theme so it is easier to configure.
| Reported by: | Eric Durocher | Owned by: | Damien Mandrioli |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.9 |
| Component: | DojoX Mobile | Version: | 1.8.1 |
| Keywords: | Cc: | Eric Durocher, cjolif | |
| Blocked By: | Blocking: |
Description
The Custom theme should be easier to configure, through a limited set of Less variables. This is already partially the case, but there is room for improvement so that only a very small number of variables have to be changed.
Attachments (1)
Change History (8)
comment:1 Changed 7 years ago by
| Milestone: | tbd → 1.9 |
|---|
comment:2 Changed 7 years ago by
| Cc: | Eric Durocher added |
|---|---|
| Owner: | changed from Eric Durocher to Damien Mandrioli |
| Status: | new → assigned |
comment:3 Changed 6 years ago by
| Cc: | cjolif added |
|---|
comment:4 Changed 6 years ago by
comment:5 Changed 6 years ago by
Sorry for indentation, spaces are now tabs.
Numbered colors are not primary since they are derived from lightColor and darkColor. Moreover each color is used in many places so it would be difficult to find meaningful names for them.
Changed 6 years ago by
| Attachment: | patch16180.patch added |
|---|
Make custom theme more generic (Damien Mandrioli, IBM CCLA)
comment:6 Changed 6 years ago by
committed in [30563]. Will be closed once documentation & release notes are updated.
comment:7 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
It seems the ticket is moving a lot of CSS code from tab to space. If I look at dijit less files they seem to be tab indented. Is there a strong reason reverting that for mobile? Also I was wondering if we could find more explicit names for our "primary" colors than 02, 03...? Maybe not? Or maybe at least for a subset?