Opened 7 years ago

Closed 7 years ago

#16180 closed enhancement (fixed)

Improve Custom theme so it is easier to configure.

Reported by: Eric Durocher Owned by: Damien Mandrioli
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc: Eric Durocher, cjolif
Blocked By: Blocking:

Description

The Custom theme should be easier to configure, through a limited set of Less variables. This is already partially the case, but there is room for improvement so that only a very small number of variables have to be changed.

Attachments (1)

patch16180.patch (69.7 KB) - added by Damien Mandrioli 7 years ago.
Make custom theme more generic (Damien Mandrioli, IBM CCLA)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Eric Durocher

Milestone: tbd1.9

comment:2 Changed 7 years ago by Eric Durocher

Cc: Eric Durocher added
Owner: changed from Eric Durocher to Damien Mandrioli
Status: newassigned

comment:3 Changed 7 years ago by cjolif

Cc: cjolif added

comment:4 Changed 7 years ago by cjolif

It seems the ticket is moving a lot of CSS code from tab to space. If I look at dijit less files they seem to be tab indented. Is there a strong reason reverting that for mobile? Also I was wondering if we could find more explicit names for our "primary" colors than 02, 03...? Maybe not? Or maybe at least for a subset?

comment:5 Changed 7 years ago by Damien Mandrioli

Sorry for indentation, spaces are now tabs.

Numbered colors are not primary since they are derived from lightColor and darkColor. Moreover each color is used in many places so it would be difficult to find meaningful names for them.

Changed 7 years ago by Damien Mandrioli

Attachment: patch16180.patch added

Make custom theme more generic (Damien Mandrioli, IBM CCLA)

comment:6 Changed 7 years ago by cjolif

committed in [30563]. Will be closed once documentation & release notes are updated.

comment:7 Changed 7 years ago by cjolif

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.