Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16179 closed enhancement (fixed)

Create an Android 4 theme

Reported by: Eric Durocher Owned by: Damien Mandrioli
Priority: high Milestone: 1.9
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description

Android 4 has a different look than previous versions so Dojo Mobile should provide a distinct theme for this platform.

Attachments (5)

holodark.patch (209.8 KB) - added by Damien Mandrioli 7 years ago.
Holo dark theme (Damien Mandrioli, IBM CCLA)
images.zip (32.5 KB) - added by Damien Mandrioli 7 years ago.
Theme images: unzip in themes/holodark directory
holodark_integration.patch (2.2 KB) - added by Damien Mandrioli 7 years ago.
Library integration of the theme: Modifies deviceTheme, _PickerChooser and index.html (Damien Mandrioli, IBM CCLA)
holodark_searchbox_patch.patch (2.3 KB) - added by Damien Mandrioli 7 years ago.
Missing CSS added by #16181 (Damien Mandrioli, IBM CCLA)
holo-css3-improvement.patch (19.7 KB) - added by Damien Mandrioli 7 years ago.
Move webkit-xxx to css3.less, Indent css3.less

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by Eric Durocher

Milestone: tbd1.9
Priority: undecidedhigh

comment:2 Changed 7 years ago by Eric Durocher

Owner: changed from Eric Durocher to Damien Mandrioli
Status: newassigned

Changed 7 years ago by Damien Mandrioli

Attachment: holodark.patch added

Holo dark theme (Damien Mandrioli, IBM CCLA)

comment:3 Changed 7 years ago by Damien Mandrioli

comment:4 Changed 7 years ago by cjolif

Ideally we should plan a refactoring of that to make sure one can pick holo dark vs holo light based on some less variables but a first holo dark version seems reasonable and this can wait a future release if we don't have time for it now.

This also needs deviceTheme be modified accordingly as well I suppose (maybe with an option/has flag for compatibility behavior).

Last edited 7 years ago by cjolif (previous) (diff)

Changed 7 years ago by Damien Mandrioli

Attachment: images.zip added

Theme images: unzip in themes/holodark directory

Changed 7 years ago by Damien Mandrioli

Attachment: holodark_integration.patch added

Library integration of the theme: Modifies deviceTheme, _PickerChooser and index.html (Damien Mandrioli, IBM CCLA)

comment:5 Changed 7 years ago by cjolif

In [30309]:

refs #16179. Holo dark theme for Android 3+. Thanks Damien Mandrioli, (IBM CCLA).

comment:6 Changed 7 years ago by cjolif

I let the ticket open until this is documented / release noted.

comment:7 Changed 7 years ago by cjolif

In [30362]:

refs #16179. Remove un-needed files (dojox/mobile/app support) that are breaking the build.

Changed 7 years ago by Damien Mandrioli

Missing CSS added by #16181 (Damien Mandrioli, IBM CCLA)

comment:8 Changed 7 years ago by cjolif

Resolution: fixed
Status: assignedclosed

Changed 7 years ago by Damien Mandrioli

Attachment: holo-css3-improvement.patch added

Move webkit-xxx to css3.less, Indent css3.less

comment:9 Changed 7 years ago by cjolif

In [30762]:

refs #16179. Move webkit-xxx to css3.less, Indent css3.less. Thanks Damien Mandrioli (IBM, CCLA).

Note: See TracTickets for help on using tickets.