Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16171 closed defect (fixed)

BB10 sniff + deviceTheme support

Reported by: dylan Owned by: cjolif
Priority: high Milestone: 1.8.2
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc: Eric Durocher
Blocked By: Blocking:

Description (last modified by dylan)

RIM has a new user agent string (BB10)... http://devblog.blackberry.com/2012/08/blackberry-10-user-agent-string/

It would be nice to fix this for deviceTheme and backport to earlier versions of Dojo to at least pull in the BB 6 or 7 theme. When BB10 is ready, we can add a full theme.

Attachments (1)

16171.patch (972 bytes) - added by Eric Durocher 7 years ago.
Support for new BB10 userAgent string - Eric Durocher (IBM, CCLA)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by dylan

Description: modified (diff)

comment:2 Changed 7 years ago by cjolif

Cc: Eric Durocher added

comment:3 Changed 7 years ago by mimendoza

This would be ideal to include it for the next update to Dojo 1.8. It would be very useful for a developer to use the deviceTheme module in their BlackBerry? app rather than direct linking to the BlackBerry? css theme file. Tutorials and resource materials that use deviceTheme would be easier/straightforward for BlackBerry? devs.

BBOS 7 theme can be used in the meantime until the BB10 theme is available.

Michelle Mendoza | RIM Developer Relations

comment:4 Changed 7 years ago by cjolif

hi mmendoza, do you have a CLA patch for that? If yes I suppose we can try to get it in 1.8.2 even if we don't have official support for BB10.

comment:5 Changed 7 years ago by mimendoza

I haven't signed a CLA yet, but I think all that is needed is adding another entry in the deviceTheme.js file under the "this.themeMap" variable. The user agent for BlackBerry? 10 devices will have the string "BB10" in it.

Changed 7 years ago by Eric Durocher

Attachment: 16171.patch added

Support for new BB10 userAgent string - Eric Durocher (IBM, CCLA)

comment:6 Changed 7 years ago by Eric Durocher

Summary: BB10 deviceTheme supportBB10 sniff + deviceTheme support

Patch to support BB10 userAgent string. Note this also patches dojox/mobile/sniff.js to set the has("bb") feature. Tested on Chrome with a modified userAgent string, should be tested on a real BB10 device...

comment:7 Changed 7 years ago by cjolif

mimendoza, did you get a chance to test the patch?

comment:8 Changed 7 years ago by cjolif

In [29958]:

refs #16171. Recognize BlackBerry? 10 as a BlackBerry?.

comment:9 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [29959]:

fixes #16171. Recognize BlackBerry?? 10 as a BlackBerry??. 1.8 backport.

comment:10 Changed 7 years ago by cjolif

Milestone: 1.91.8.2

comment:11 Changed 7 years ago by mimendoza

I've tested it and it works as expected. Thanks cjolif.

Note: See TracTickets for help on using tickets.