Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1617 closed defect (fixed)

Multiple dojo.provide() calls in files should be deleted

Reported by: owen Owned by: owen
Priority: high Milestone:
Component: Loader Version: 0.3
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by owen)

The following files have mutliple dojo.provide() calls in them. Each file should have only a single provide(), which maps to the file name. Other provides() should be deleted.

DragAndDrop.js
HtmlDragAndDrop.js
HtmlDragCopy.js
HtmlDragMove.js
TreeDragAndDrop.js
TreeDragAndDropV3.js
RepubsubIO.js
XhrIframeProxy.js
Animation.js
Logger.js
regexp.js
storage/browser.js
storage/storage.js
textDirectory.js
AnimatedPng.js
Chart.js
Editor.js
Editor2.js
CreateLinkDialog.js
FindReplaceDialog.js
InsertImageDialog.js
InsertTableDialog.js
FisheyeList.js
SvgWidget.js
TaskBar.js
Toolbar.js
TreeContextMenu.js
TreeContextMenuV3.js
Widget.js

Change History (4)

comment:1 Changed 8 years ago by owen

  • Description modified (diff)

comment:2 Changed 8 years ago by bill

  • Owner changed from alex to owen

comment:3 Changed 8 years ago by owen

  • Resolution set to fixed
  • Status changed from new to closed
REMOVED:
* dnd.DragAndDrop.js
	dojo.provide("dojo.dnd.DragSource");
	dojo.provide("dojo.dnd.DropTarget");
	dojo.provide("dojo.dnd.DragObject");
* dnd.HtmlDragAndDrop.js
	dojo.provide("dojo.dnd.HtmlDragSource");
	dojo.provide("dojo.dnd.HtmlDropTarget");
	dojo.provide("dojo.dnd.HtmlDragObject");
* dnd/HtmlDragCopy.js
	dojo.provide("dojo.dnd.HtmlDragCopySource");
	dojo.provide("dojo.dnd.HtmlDragCopyObject");
* dnd/HtmlDragMove.js
	dojo.provide("dojo.dnd.HtmlDragMoveSource");
	dojo.provide("dojo.dnd.HtmlDragMoveObject");
* dnd/TreeDragAndDrop.js
	dojo.provide("dojo.dnd.TreeDragSource");
	dojo.provide("dojo.dnd.TreeDropTarget");
	dojo.provide("dojo.dnd.TreeDNDController");
* dnd/TreeDragAndDropV3.js
	dojo.provide("dojo.dnd.TreeDragSourceV3");
	dojo.provide("dojo.dnd.TreeDropTargetV3");
* io/cometd.js
	dojo.provide("cometd");
* io/RepubsubIO.js
	dojo.provide("dojo.io.repubsub");
	dojo.provide("dojo.io.repubsubTransport");
* io/XhrIframeProxy.js
	dojo.provide("dojo.io.XhrIframeFacade");
* lfx/Animation.js
	dojo.provide("dojo.lfx.Line");
* logging/Logger.js
	dojo.provide("dojo.log");
* regexp.js
	dojo.provide("dojo.regexp.us");
* storage/browser.js
	dojo.provide("dojo.storage.browser.FlashStorageProvider");
* text/textDirectory.js
	dojo.provide("dojo.text.textDirectory.Property");
	dojo.provide("dojo.text.textDirectory.tokenise");
* widget/Chart.js
	dojo.provide("dojo.widget.Chart.DataSeries");
* widget/Editor2.js
	dojo.provide("dojo.widget.Editor2Manager");
* widget/Editor2Plugin/CreateLinkDialog.js
	dojo.provide("dojo.widget.Editor2CreateLinkDialog");
* widget/Editor2Plugin/FindReplaceDialog.js
	dojo.provide("dojo.widget.Editor2FindDialog");
	dojo.provide("dojo.widget.Editor2ReplaceDialog");
* widget/Editor2Plugin/InsertImageDialog.js
	dojo.provide("dojo.widget.Editor2InsertImageDialog");
* widget/Editor2Plugin/InsertTableDialog.js
	dojo.provide("dojo.widget.Editor2InsertTableDialog");
* widget/FisheyeList.js
	dojo.provide("dojo.widget.FisheyeListItem");
* widget/SplitContainer.js
	dojo.provide("dojo.widget.SplitContainerPanel");
* widget.TaskBar.js
	dojo.provide("dojo.widget.TaskBarItem");
* widget.Toolbar.js
	dojo.provide("dojo.widget.ToolbarContainer");
	dojo.provide("dojo.widget.ToolbarItem");
	dojo.provide("dojo.widget.ToolbarButtonGroup");
	dojo.provide("dojo.widget.ToolbarButton");
	dojo.provide("dojo.widget.ToolbarDialog");
	dojo.provide("dojo.widget.ToolbarMenu");
	dojo.provide("dojo.widget.ToolbarSeparator");
	dojo.provide("dojo.widget.ToolbarSpace");
	dojo.provide("dojo.widget.Icon");
* widget/TreeContextMenu.js
	dojo.provide("dojo.widget.TreeMenuItem");
* widget/TreeContextMenuV3.js
	dojo.provide("dojo.widget.TreeMenuItemV3");
* widget/Widget.js
	dojo.provide("dojo.widget.tags");





CLEANED UP
* storage.js
	dojo.provide("dojo.storage.StorageProvider");
	-- Added dojo.storage.StorageProvider = {}


IGNORED BECAUSE IT WAS WIERD
* dojo.widget.SvgWidget.js
	dojo.provide("dojo.widget.SVGWidget"); // back compat


TESTING ON THESE PAGES HAD SOME WIERDNESS, NOT SURE IT'S RELATED
	file:///www/dojo/trunk/tests/widget/Editor/test_Editor2InsideDialog.html

comment:4 Changed 7 years ago by anonymous

  • Milestone 0.4 deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.