Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16164 closed defect (fixed)

dojox/mobile: some properties of subclasses of _ItemBase cannot be set before completion of startup

Reported by: Adrian Vasiliu Owned by: Eric Durocher
Priority: undecided Milestone: 1.8.2
Component: DojoX Mobile Version: 1.8.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by cjolif)

For some of its properties, dojox/mobile/ListItem has a special mechanism to delay the actual execution of custom setters until the startup of the widget is completed. This holds for the following properties: checked, icon, rightIcon, rightIcon2, uncheckIcon, deleteIcon

The trouble is that, for a code which attempts to set values to these properties before the startup completion, the final values of the properties are not the expected ones.

This hurts dojox/mvc, where the binding mechanism involves calls of the setters before widget startup completion.

The same holds for the "icon" property of IconItem, IconMenuItem, TabBarButton, and ToolBarButton.

How to reproduce:

a) Run dojox/mvc/tests/WidgetList_tests/test_mobile-list-single-sel-mvc.html

If the bug is present, the first item in the list does not show the "checked" mark.

or

b) Run the attached ItemBase_subclasses_Programmatic.html

This is a DOH tests which mimics what happens in the dojox/mvc context without using dojox/mvc. If the bug is present, the test fails.

Attachments (1)

patch16164.patch (20.1 KB) - added by Adrian Vasiliu 7 years ago.
Fix incorrect values of properties when they are set before startup completion. Includes a new DOH test for dojox/mobile and the removal of a workaround from a dojox/mvc test. - Adrian Vasiliu, IBM, CCLA

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch16164.patch added

Fix incorrect values of properties when they are set before startup completion. Includes a new DOH test for dojox/mobile and the removal of a workaround from a dojox/mvc test. - Adrian Vasiliu, IBM, CCLA

comment:1 Changed 7 years ago by Adrian Vasiliu

This may be a temporary solution - at a later stage we may revisit the design of setters/getters.

comment:2 Changed 7 years ago by cjolif

Description: modified (diff)
Summary: dojox/mobile: some properties of ListItem cannot be set before completion of startupdojox/mobile: some properties of subclasses of _ItemBase cannot be set before completion of startup

comment:3 Changed 7 years ago by Ed Chatelain

Resolution: fixed
Status: newclosed

In [29826]:

Fixes #16164. some properties of subclasses of _ItemBase cannot be set before completion of startup. Thanks Adrian Vasiliu (IBM, CCLA). !strict

comment:4 Changed 7 years ago by Ed Chatelain

In [29827]:

Refs #16164. some properties of subclasses of _ItemBase cannot be set before completion of startup. Thanks Adrian Vasiliu (IBM, CCLA). !strict

comment:5 Changed 7 years ago by Ed Chatelain

Milestone: tbd1.8.2
Note: See TracTickets for help on using tickets.