#16159 closed defect (duplicate)
Issues with loading some Node.js Modules
| Reported by: | Kitson Kelly | Owned by: | Colin Snover |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9 |
| Component: | Core | Version: | 1.8.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Sometimes when attempting to load certain Node.js modules that might relay on code that attempts to detect if it is running in an AMD environment with dojo/node, it can cause issues where it thinks it should be dealing with define() when in fact it shouldn't and instead return values as part of the module export.
When requiring a module, the scope should be limited via a closure and define "descoped" in order for the code to execute properly.
I have attached a patch which resolves this issue.
Attachments (1)
Change History (5)
comment:1 Changed 9 years ago by
| Owner: | set to Colin Snover |
|---|---|
| Status: | new → assigned |
Changed 9 years ago by
| Attachment: | node.js.patch added |
|---|
comment:2 Changed 9 years ago by
| Milestone: | tbd → 1.9 |
|---|---|
| Priority: | undecided → blocker |
ugh, this did not get fixed? thought it did. fixing now.
comment:3 Changed 9 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | assigned → closed |
Duplicate of #16414.
Excuse you kitsonk, creating duplicate tickets, sheesh! :)
Note: See
TracTickets for help on using
tickets.
Patches dojo/node to scope out define