[patch] Invalid 'in' operand, using Cache with JsonRest PUT

[nosuchluke]

var store = new Cache(new JsonRest({ target: "/stuff" }), new Memory());
store.put({id:1}).then(null, function(err){alert(err);});

Result:

TypeError: invalid 'in' operand _7

This seems to result when the PUT returns a 204 or no-content 200, which is correct REST behavior. The result from JsonRest.put() is null, then in Cache we get to:

cachingStore.put(typeof result == "object" ? result : object, directives);

Since null is of type object, null gets passed to Memory, which then vomits in disgust.

Someone else encountered the problem ​here.

[Kris Zyp]

In [29843]:

Check for objects with a truthy clause to avoid nulls, fixes #16158

[dylan]

Reopened because of ​https://github.com/dojo/dojo/pull/40

[dylan]

Fix is trivial, so no CLA needed.

[Kris Zyp <[email protected]…>]

In 9b974ae1d7c53879676d818025b16b7a8d2874fd/dojo:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?