Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16137 closed defect (fixed)

[patch][CCLA] dijit.Form - update dijit.form test pages to be fully accessible

Reported by: mikeb Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.2
Component: Dijit - Form Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description

Update all of the pages in the dijit/tests/form/ directory to be fully accessible with screen readers and automated tools. This will make it much easier in the future to run automated accessibility test tools and also will show the accessibility features of Dojo.

Some of the test pages in this patch may have already been updated by other dijit.form accessibility patches, I just decided to include them all in the patch in case there are problems with the other tickets.

Attachments (1)

dijit-test-pages.patch​ (126.4 KB) - added by mikeb 7 years ago.
make dijit test pages fully accessible and compliant with wai-aria spec to ease future testing, please proxy commit for Michael Billau CCLA on file with IBM

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by mikeb

Attachment: dijit-test-pages.patch​ added

make dijit test pages fully accessible and compliant with wai-aria spec to ease future testing, please proxy commit for Michael Billau CCLA on file with IBM

comment:1 Changed 7 years ago by Douglas Hays

Milestone: tbd → 1.8.2

comment:2 Changed 7 years ago by mikeb

I'm pretty sure that ​http://bugs.dojotoolkit.org/ticket/16078 needs to be committed first, because the majority of the changes involve adding aria-label attribute to the form elements.

comment:3 Changed 7 years ago by Douglas Hays

Resolution: → fixed
Status: new → closed

In [29812]:

Fixes #16137. Proxy commit for Mike Billau (IBM, CCLA). Fix form test a11y violations generated by RPT.

comment:4 Changed 7 years ago by bill

In [30258]:

Better markup for checkboxes and radio buttons. Also fixing test code to use strings for the checkbox and radio button values, since the values are strings, not numbers. Refs #16137.

comment:5 Changed 7 years ago by inghamc

Doug - your fix for this defect introduced an HTML syntax error at line 250 of ExpandingTextAreaMixin?.html - the <body tag no longer has its closing '>'

See ​http://bugs.dojotoolkit.org/changeset/29812/dojo/dijit/trunk/tests/form/ExpandingTextAreaMixin.html

comment:6 Changed 7 years ago by Douglas Hays

In [30692]:

Refs #16137. Correct HTML syntax error.

Note: See TracTickets for help on using tickets.