Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#16131 closed task (fixed)

IE10 StackContainer test failure

Reported by: haysmark Owned by: bill
Priority: undecided Milestone: 1.6.2
Component: Dijit Version: 1.7.4rc1
Keywords: dohfail Cc:
Blocked By: Blocking:

Description

It seems IE10 does not round at all...

 ------------------------------------------------------------
 GROUP "dijit.tests.layout.StackContainer" has 1 test to run
 11 tests to run in 7 groups
 ------------------------------------------------------------
 GROUP "nested layout widgets" has 1 test to run
     _AssertFailure: assertEqual() failed:
 	expected
		300
	but got
		299.9999809265137

 with hint: 
		BorderContainer width

     ERROR IN:
 		 function nestedLayout(){
					click("nextPR");
					var bcPos = dojo.position("bc"),
						tcPos = dojo.position("tc");

					doh.t("bc" in resizes, "BorderContainer got resize");
					doh.is(300, bcPos.w, "BorderContainer width");
					doh.is(200, bcPos.h, "BorderContainer height");

					doh.t("tc" in resizes, "TabContainer got resize");
					doh.is(300, bcPos.w, "TabContainer width");
					doh.is(200, bcPos.h, "TabContainer height");
				}
 FAILED test: ../../dijit/tests/layout/StackContainer.html::nested layout widgets::nestedLayout 79 ms

Change History (10)

comment:1 Changed 7 years ago by haysmark

Keywords: dohfail added

comment:2 Changed 7 years ago by bill

Milestone: tbd1.9
Status: newassigned

Thanks, I'll check in a fix. Since it's only changes to test I guess it doesn't need to be backported.

comment:3 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29789]:

Ignore rounding errors in StackContainer unit test, fixes #16131.

comment:4 Changed 6 years ago by haysmark

Version: 1.8.01.7.4rc1

Also present in 1.7. Would like to see the StackContainer? fixes in [29789] backported to 1.7.

comment:5 Changed 6 years ago by bill

In [29949]:

backport [29789] to 1.8 branch, refs #16131

comment:6 Changed 6 years ago by bill

In [29950]:

backport [29789] to 1.7 branch, refs #16131

comment:7 Changed 6 years ago by bill

Milestone: 1.91.7.5

comment:8 Changed 6 years ago by bill

Type: defecttask

Marking as task since it was only a test issue.

comment:9 Changed 6 years ago by bill

In [30246]:

backport IE10 test fix [29789] to 1.6 branch, refs #16131

comment:10 Changed 6 years ago by bill

Milestone: 1.7.51.6.2
Note: See TracTickets for help on using tickets.