Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16130 closed task (fixed)

IE10 LayoutContainer test failures

Reported by: haysmark Owned by: bill
Priority: undecided Milestone: 1.6.2
Component: Dijit Version: 1.7.4rc1
Keywords: dohfail Cc:
Blocked By: Blocking:

Description

It seems nothing is appearing in the list of tab-able elements?

 GROUP "LayoutContainer" has 2 tests to run
     _AssertFailure: assertTrue('false') failed with hint: 
 		top vs center top above client{"x":128,"y":109.0999984741211,"w":472,"h":29.20000457763672}{"x":128,"y":138.09999084472656,"w":472,"h":242.00001525878906}

     ERROR IN:
 		 function basic(){
					var lc = dijit.byId("basic");
					dojo.forEach(lc.getChildren(), function(child){
						checkInside(child, lc);
					});

					var left = dijit.byId("leftcp_layout1"),
						top = dijit.byId("topcp_layout1"),
						right = dijit.byId("rightcp_layout1"),
						center = dijit.byId("centercp_layout1"),
						bottom = dijit.byId("bottomcp_layout1");

					// Check positions
					checkLeft("left vs top", left, top);
					checkLeft("left vs center", left, center);
					checkLeft("bottom vs right", bottom, right);
					checkAbove("top vs center", top, center);
					checkAbove("center vs bottom", center, bottom);

					// Check tab order
					var tabbable = tabOrder(lc.domNode);
					doh.is(7, tabbable.length, "each pane plus link and select");
					doh.is(left.id, tabbable[0].id, "left");
					doh.is(right.id, tabbable[1].id, "right");
					doh.is(top.id, tabbable[2].id, "top");
					doh.is(center.id, tabbable[3].id, "center");
					doh.is(bottom.id, tabbable[6].id, "bottom");
				}
 FAILED test: ../../dijit/tests/layout/LayoutContainer.html::LayoutContainer::basic 74 ms
     _AssertFailure: assertEqual() failed:
 	expected
		8
	but got
		0

 with hint: 
		each pane plus link and select

     ERROR IN:
 		 function advanced(){
					var lc = dijit.byId("advanced");
					dojo.forEach(lc.getChildren(), function(child){
						checkInside(child, lc);
					});

					var left = dijit.byId("leftcp_layout2"),
						top = dijit.byId("topcp_layout2"),
						right = dijit.byId("rightcp_layout2"),
						centerLeft = dijit.byId("centerLeftcp_layout2"),
						center = dijit.byId("centercp_layout2"),
						centerRight = dijit.byId("centerRightcp_layout2"),
						bottom = dijit.byId("bottomcp_layout2");

					// Check positions
					checkLeft("left vs top", left, top);
					checkLeft("left vs centerLeft", left, centerLeft);
					checkLeft("centerLeft vs center", centerLeft, center);
					checkLeft("center vs centerRight", center, centerRight);
					checkAbove("top vs center", top, center);
					checkAbove("top vs inner right", top, centerRight);
					checkAbove("centerLeft vs bottom", centerLeft, bottom);

					// Check tab order
					var tabbable = tabOrder(lc.domNode);
					doh.is(8, tabbable.length, "each pane plus link and select");
					doh.is(left.id, tabbable[0].id, "left");
					doh.is(top.id, tabbable[1].id, "top");
					doh.is(bottom.id, tabbable[2].id, "bottom");
					doh.is(centerLeft.id, tabbable[3].id, "center left");
					doh.is(center.id, tabbable[4].id, "center");
					doh.is(centerRight.id, tabbable[7].id, "center right");
				}
 FAILED test: ../../dijit/tests/layout/LayoutContainer.html::LayoutContainer::advanced 58 ms
 PASSED test: ../../dijit/tests/layout/LayoutContainer.html 926 ms

Change History (10)

comment:1 Changed 7 years ago by haysmark

Keywords: dohfail added

comment:2 Changed 7 years ago by bill

Milestone: tbd1.9
Status: newassigned

Thanks, I'll check in a fix. Since it's only changes to test I guess it doesn't need to be backported.

comment:3 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29790]:

Restrict walkTree() workaround code to IE8 or less, since it actually makes things worse on IE10. Also ignore IE10 rounding errors. Fixes #16130.

comment:4 Changed 7 years ago by haysmark

Version: 1.8.01.7.4rc1

Also happens in 1.7. Would like to see [29790] backported to fix these LayoutContainer? errors.

comment:5 Changed 7 years ago by bill

In [29947]:

backport [29790] to 1.8 branch, refs #16130

comment:6 Changed 7 years ago by bill

In [29948]:

backport [29790] to 1.7 branch, refs #16130

comment:7 Changed 7 years ago by bill

Milestone: 1.91.7.5

comment:8 Changed 7 years ago by bill

Type: defecttask

Marking as task since it was only a test issue.

comment:9 Changed 7 years ago by bill

In [30243]:

backport IE10 test fix [29790] to 1.6 branch, refs #16122, #16130 !strict.

comment:10 Changed 7 years ago by bill

Milestone: 1.7.51.6.2
Note: See TracTickets for help on using tickets.